Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

undervolt: init at 0.2.5 #43597

Closed
wants to merge 1 commit into from
Closed

undervolt: init at 0.2.5 #43597

wants to merge 1 commit into from

Conversation

eadwu
Copy link
Member

@eadwu eadwu commented Jul 16, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@fpletz
Copy link
Member

fpletz commented Jul 16, 2018

@GrahamcOfBorg build undervolt

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: undervolt

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: undervolt

Partial log (click to expand)

unconvert_rounded_offset (undervolt)
Doctest: undervolt.unconvert_rounded_offset ... ok
unpack_offset (undervolt)
Doctest: undervolt.unpack_offset ... ok

----------------------------------------------------------------------
Ran 5 tests in 0.007s

OK
/nix/store/ar5030qgxf5499mczpdcrrbagz7kkhd4-undervolt-0.2.5

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: undervolt

Partial log (click to expand)

unconvert_rounded_offset (undervolt)
Doctest: undervolt.unconvert_rounded_offset ... ok
unpack_offset (undervolt)
Doctest: undervolt.unpack_offset ... ok

----------------------------------------------------------------------
Ran 5 tests in 0.034s

OK
/nix/store/c7rrdg1r94rxn7k1b7vprl4zh7qsrpkk-undervolt-0.2.5

fpletz
fpletz reviewed Jul 16, 2018
View reviewed changes
nixos/modules/services/hardware/undervolt.nix
wantedBy = [
"suspend.target"
"hibernate.target"
"hybrid-sleep.target"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you test this? Aren't those three targets activated before the actual suspend/sleep?

The powerManagement.resumeCommands option is probably more useful.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved cfg under powerManagement while also using powerManagement.powerUpCommands.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, powerManagement.powerUpCommands fails when booting up while powerManagement.resumeCommands doesn't run at boot. Just returned back to the service.

@eadwu eadwu force-pushed the init/undervolt branch 4 times, most recently from 238674c to 8524131 Compare July 16, 2018 20:42
@eadwu
Copy link
Member Author

eadwu commented Aug 12, 2018

In favor of #44919

@eadwu eadwu closed this Aug 12, 2018
@eadwu eadwu deleted the init/undervolt branch November 17, 2020 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz fpletz left review comments

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eadwu @fpletz @GrahamcOfBorg