Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gscrabble: init at unstable-2019-03-11 #44505

Merged
merged 1 commit into from Mar 30, 2019
Merged

Conversation

bignaux
Copy link
Contributor

@bignaux bignaux commented Aug 5, 2018

Motivation for this change

i had to restore gnome3.gnome-icon-theme-symbolic , some review about it needed.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

pkgs/games/gscrabble/default.nix Outdated Show resolved Hide resolved
pkgs/games/gscrabble/default.nix Outdated Show resolved Hide resolved
pkgs/games/gscrabble/default.nix Outdated Show resolved Hide resolved
pkgs/games/gscrabble/default.nix Outdated Show resolved Hide resolved
pkgs/games/gscrabble/default.nix Outdated Show resolved Hide resolved
pkgs/games/gscrabble/default.nix Outdated Show resolved Hide resolved
@bignaux bignaux changed the title [WIP] gscrabble : init at 0.1.2 [WIP] gscrabble : init at 2019-03-11 Mar 25, 2019
@GrahamcOfBorg GrahamcOfBorg removed the 6.topic: GNOME GNOME desktop environment and its underlying platform label Mar 25, 2019
@bignaux bignaux changed the title [WIP] gscrabble : init at 2019-03-11 gscrabble : init at 2019-03-11 Mar 26, 2019
@bignaux bignaux changed the title gscrabble : init at 2019-03-11 gscrabble: init at unstable-2019-03-11 Mar 28, 2019
@bignaux
Copy link
Contributor Author

bignaux commented Mar 29, 2019

@jtojnar : i think all is good now ;)

@jtojnar
Copy link
Contributor

jtojnar commented Mar 29, 2019

Hmm, I am getting

/nix/store/sck8x99a3lsjlxwns4sgy1zaf8ll31hc-gvfs-1.38.1/lib/gio/modules/libgioremote-volume-monitor.so: undefined symbol: g_mount_operation_get_is_tcrypt_system_volume
Failed to load module: /nix/store/sck8x99a3lsjlxwns4sgy1zaf8ll31hc-gvfs-1.38.1/lib/gio/modules/libgioremote-volume-monitor.so

** (gst-plugin-scanner:9640): CRITICAL **: 12:18:04.914: pygobject initialization failed

pkgs/games/gscrabble/default.nix Outdated Show resolved Hide resolved
pkgs/games/gscrabble/default.nix Outdated Show resolved Hide resolved
@flokli
Copy link
Contributor

flokli commented Mar 29, 2019

This still fails to run for me:

Traceback (most recent call last):
  File "/nix/store/92wzfvip0pvkhzi44029hybm7vjmwxdh-gscrabble-unstable-2019-03-11/bin/..gscrabble-wrapped-wrapped", line 15, in <module>
    import gscrabble
  File "/nix/store/92wzfvip0pvkhzi44029hybm7vjmwxdh-gscrabble-unstable-2019-03-11/share/GScrabble/modules/gscrabble.py", line 11, in <module>
    gi.require_version('Gst', '1.0')
  File "/nix/store/bncy9d114kp08ln751f89qvgb674j6qf-python3.7-pygobject-3.30.4/lib/python3.7/site-packages/gi/__init__.py", line 129, in require_version
    raise ValueError('Namespace %s not available' % namespace)
ValueError: Namespace Gst not available

It seems the GI overrides from ${python3.pkgs.gst-python}/lib/python3.7/site-packages/gi/overrides are not being picked up.

I however don't know how the gio override magic works :-)

pkgs/games/gscrabble/default.nix Outdated Show resolved Hide resolved
];

propagatedBuildInputs = [
gst-python
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's also a pkgs.gst-python, so we probably should refer python3.pkgs.gst-python here explicitly.

@bignaux
Copy link
Contributor Author

bignaux commented Mar 29, 2019

i've environment.variables.GIO_EXTRA_MODULES = [ "${pkgs.gvfs}/lib/gio/modules" ]; # lets PCManFM discover gvfs modules from https://nixos.wiki/wiki/Samba (that failed as all of this documentation on the wiki ) but perharps it covers me to see such bug. I should have a closer look at this. btw there is a lot of bugs about gi around, i'm not confident the problem is from my derivation ... i've gvfs-1.36 for information.

@bignaux
Copy link
Contributor Author

bignaux commented Mar 30, 2019

i've git rebase and fix things, hope it's good now.

@flokli
Copy link
Contributor

flokli commented Mar 30, 2019

Got it to run without erroring out, but the language selection seems to be buggy. I couldn't switch using something other than Arabic (or am to stupid to figure out where to click).

Any idea what fixed the Namespace Gst not available error now?

What about the version number? Readme in the upstream repo mentions 0.1.2, but there seem to be neither tags nor release tarballs. Could you ask upstream to make a release (maybe after the language selection is fixed)?

@bignaux
Copy link
Contributor Author

bignaux commented Mar 30, 2019

the language selection seems to be buggy. I couldn't switch using something other than Arabic (or am to stupid to figure out where to click).

Yes you need to fix in the preference, it wont work from start screen.

Any idea what fixed the Namespace Gst not available error now?

Can't be sure since i didn't have this problem with my old git tree. I think the alias gobjectIntrospection wont work but in my old tree, that was the official name.

What about the version number? Readme in the upstream repo mentions 0.1.2, but there seem to be neither tags nor release tarballs. Could you ask upstream to make a release (maybe after the language selection is fixed)?

If there is no tagged i take the latest that fix things for us ( RaaH/gscrabble#3 )
and since i've already 2 PR pending on this, i'll wait finish french translation and more worried bug without ask for a release. It took 7 months for jtojnar to have an answer ...

@flokli
Copy link
Contributor

flokli commented Mar 30, 2019

Well, I assume you'll maintain the package here and bump once the french translations or bugs are fixed, and take care asking upstream about a release ;-)

@flokli flokli changed the title gscrabble: init at unstable-2019-03-11 gscrabble: init at unstable-2019-03-11 Mar 30, 2019
@flokli flokli merged commit db83699 into NixOS:master Mar 30, 2019
@bignaux bignaux deleted the gscrabble branch March 30, 2019 21:19
bignaux referenced this pull request in RaaH/gscrabble Apr 10, 2019
add french traduction
@FlorianFranzen
Copy link
Contributor

Started hitting the same issue as @jtojnar when trying to open a PDF with Zathura, which used to work just before the last channel update about 2 weeks ago.

/nix/store/cvzabqj2wiymkkrdw0l0mk6pw9rkdx4v-gvfs-1.40.1/lib/gio/modules/libgioremote-volume-monitor.so: undefined symbol: g_mount_operation_get_is_tcrypt_system_volume
Failed to load module: /nix/store/cvzabqj2wiymkkrdw0l0mk6pw9rkdx4v-gvfs-1.40.1/lib/gio/modules/libgioremote-volume-monitor.so

@jtojnar
Copy link
Contributor

jtojnar commented May 22, 2019

@FlorianFranzen looks like some kind of impurity. Please open a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants