pybitmessage: 0.6.2 -> 0.6.3.2 #44510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dotlambda should this explicitly use python3 as well? |
dotlambda
requested changes
Aug 5, 2018
|
|
||
| src = fetchFromGitHub { | ||
| owner = "bitmessage"; | ||
| repo = "PyBitmessage"; | ||
| rev = "v${version}"; | ||
| sha256 = "04sgns9qczzw2152gqdr6bjyy4fmgs26cz8n3qck94l0j51rxhz8"; | ||
| rev = "${version}"; |
| @@ -3,13 +3,13 @@ | |||
| pythonPackages.buildPythonApplication rec { | |||
| name = "pybitmessage-${version}"; | |||
There was a problem hiding this comment.
Replace this line by pname = "pybitmessage";.
No, PyBitmessage is python2 only: https://github.com/Bitmessage/PyBitmessage/blob/b0446ab4ab08def782b7f6fb6b7ca5c8d3d7f0c0/setup.py#L103 |
dotlambda
added
1.severity: security
9.needs: port to stable
pybitmessage does not support python3 yet
|
@GrahamcOfBorg build pybitmessage |
|
Failure on x86_64-linux (full log) Attempted: pybitmessage Partial log (click to expand)
|
|
Failure on aarch64-linux (full log) Attempted: pybitmessage Partial log (click to expand)
|
|
Someone broke qt in the meantime :-/ |
|
It's not broken. We'll just have to wait until |
|
@GrahamcOfBorg build pybitmessage |
|
Success on x86_64-linux (full log) Attempted: pybitmessage Partial log (click to expand)
|
|
Backported in ad66494. |
|
Failure on aarch64-linux (full log) Attempted: pybitmessage Partial log (click to expand)
|
samueldr
removed
the
9.needs: port to stable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Fixes a RCE vulnerability
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)/cc @jgillich