pmdk: init at 1.4.1 #44485
Closed
pmdk: init at 1.4.1 #44485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
symphorien
reviewed
Aug 5, 2018
maintainers/maintainer-list.nix
Outdated
| barakb = { | ||
| email = "barak.bar@gmail.com"; | ||
| github = "barakb"; | ||
| name = "Barak Bar Orion" |
There was a problem hiding this comment.
; is missing at the enf of line
symphorien
reviewed
Aug 5, 2018
| pkgconfig | ||
| autoconf | ||
| automake | ||
| doxygen |
There was a problem hiding this comment.
pkgconfig autoconf automake and doxygen are probably only needed at build time so should be nativeBuildInputs
symphorien
reviewed
Aug 5, 2018
| ''; | ||
|
|
||
| meta = { | ||
| description = "Persistance memory programming"; |
There was a problem hiding this comment.
maybe you meant "persistent" instead of "persistance" ?
pSub
reviewed
Aug 5, 2018
| }: | ||
|
|
||
| stdenv.mkDerivation rec { | ||
| name="pmdk-1.4.1"; |
There was a problem hiding this comment.
If you declare the version separately like version = "1.4.1" you can use it for the revision in fetchFromGitHub like rev = version and of course in name like name ="pmdk-${version}".
pmdk is a persistent memory development kit
|
You can force push to your branch instead of closing/reopening a pull request :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pmdk is a persistent Memory Development Kit
Motivation for this change
PMDK package is missing from Nix repostitory
Things done
Add Nix package that fetch PMDK from git and build it.
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)