Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stdenv: simplify a bit using shadowing #44517

Merged
merged 2 commits into from
Aug 8, 2018
Merged

stdenv: simplify a bit using shadowing #44517

merged 2 commits into from
Aug 8, 2018
+20 −21

Conversation

oxij
Copy link
Member

@oxij oxij commented Aug 5, 2018

Motivation for this change

Discussion in #39464 (comment)

/cc @Ericson2314

oxij added 2 commits August 5, 2018 19:24
@oxij
stdenv: shadow doCheck and doInstallCheck

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
a53504f
@oxij
stdenv: shadow outputs
eb5b313
@GrahamcOfBorg GrahamcOfBorg added 6.topic: stdenv Standard environment 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild 10.rebuild-linux-stdenv This PR causes stdenv to rebuild 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+ labels Aug 5, 2018
@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: stdenv

Partial log (click to expand)

cannot build derivation ‘/nix/store/82k222n78k6dk7lpy3lsnya7jvc29v3i-gnutar-1.30.drv’: 2 dependencies couldn't be built
cannot build derivation ‘/nix/store/n73b7hi28phjixdsja3hm0iwdwz130a8-lzip-1.20.drv’: 2 dependencies couldn't be built
cannot build derivation ‘/nix/store/vrfcx3kppxabv391g3kghxpa0nbd0jp3-binutils-wrapper-2.30.drv’: 4 dependencies couldn't be built
cannot build derivation ‘/nix/store/1pc118s47wdwpfqf401mbybhs6r6vawh-diffutils-3.6.drv’: 3 dependencies couldn't be built
cannot build derivation ‘/nix/store/r6sa40nancl069fdwc48qnd5kjragb4r-ed-1.14.2.drv’: 2 dependencies couldn't be built
cannot build derivation ‘/nix/store/p95ad017x4anfmznxkhmldzbi01ancgm-findutils-4.6.0.drv’: 2 dependencies couldn't be built
cannot build derivation ‘/nix/store/fl3a1cappy75c11xyi8vlzd1j9alypdq-gcc-wrapper-7.3.0.drv’: 5 dependencies couldn't be built
cannot build derivation ‘/nix/store/15y50jrxx14r03p0rrnhfb4d18jbhr4h-patch-2.7.6.drv’: 2 dependencies couldn't be built
cannot build derivation ‘/nix/store/y0za17cvyfg7a16vv5kb7n9r4hmd34jz-stdenv-linux.drv’: 24 dependencies couldn't be built
error: build of ‘/nix/store/y0za17cvyfg7a16vv5kb7n9r4hmd34jz-stdenv-linux.drv’ failed

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: stdenv

Partial log (click to expand)

cannot build derivation '/nix/store/vgmfwqgm4qj7ajvc7h7p40h6cb6gsddq-gnutar-1.30.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/qqcsy0vhngjbmb5iar0y3g2mg1d3is8c-lzip-1.20.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/458g3kn6gpa44nxzrxij3zr00dni8wy4-binutils-wrapper-2.30.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/7n7n02w5jsiqy9xqw3z051kiahcqy5k1-diffutils-3.6.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/qqfxj7pq5zp62i68dwmga1fx0kcj25nw-ed-1.14.2.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/jjp6gs7bhnzih0krsj7ipqlbrdyldyg0-findutils-4.6.0.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/nj6z0djp0c5dla9p3ma441c2vi9aizs3-gcc-wrapper-7.3.0.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/nzcipyzlj248hsh0s7qkvydypkwkl734-patch-2.7.6.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/i7acxqcdsvkj5c9ywhwijpsjzldlhg8z-stdenv-linux.drv': 26 dependencies couldn't be built
error: build of '/nix/store/i7acxqcdsvkj5c9ywhwijpsjzldlhg8z-stdenv-linux.drv' failed

@oxij oxij mentioned this pull request Aug 6, 2018
Merged
@oxij
Copy link
Member Author

oxij commented Aug 6, 2018 via email

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: stdenv

Partial log (click to expand)

cannot build derivation '/nix/store/k1ggxx7idk0q2k6inpv064sb64csifdd-binutils-wrapper-2.30.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/6nxca4dy81ga195n2y7wk34hmxj2q6hh-diffutils-3.6.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/hpn0hkr3jx763l3l3as1ndgy3v45whzk-ed-1.14.2.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/f9c2bqj0wz3d9aafxcd9sy5y64xjw6xz-findutils-4.6.0.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/557qq6ph2v6n69n6rm44pd23z1wk0ij8-libtool-2.4.6.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/jcxl784q293ij973fd8fa9a1a0s5357f-gcc-wrapper-7.3.0.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/2mql4y2200q97qnsa2kdj4dzplvq91ld-hook.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/7qvyyqs3zdn27nypnr6arnz6azwqcf2b-patch-2.7.6.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/2mfjnnf4s5mv5fhcd3hcj0ya3dhpimkf-stdenv-linux.drv': 24 dependencies couldn't be built
error: build of '/nix/store/2mfjnnf4s5mv5fhcd3hcj0ya3dhpimkf-stdenv-linux.drv' failed

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: stdenv

Partial log (click to expand)

cannot build derivation '/nix/store/458g3kn6gpa44nxzrxij3zr00dni8wy4-binutils-wrapper-2.30.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/7n7n02w5jsiqy9xqw3z051kiahcqy5k1-diffutils-3.6.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/qqfxj7pq5zp62i68dwmga1fx0kcj25nw-ed-1.14.2.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/jjp6gs7bhnzih0krsj7ipqlbrdyldyg0-findutils-4.6.0.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/lmr4kfrzp45s23sj7y4vac30di5y294c-libtool-2.4.6.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/r0zvbksx6ggbd446gjmxrrsx1x04kzq5-gcc-wrapper-7.3.0.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/mf9rdg587a9i3wy8z3jqgqwsmqff0w2p-hook.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/dhavygq8yhfs37ilis8641g3nbs5wdlm-patch-2.7.6.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/r727rb5g76xzmprli54srrhklxbpyr0x-stdenv-linux.drv': 26 dependencies couldn't be built
error: build of '/nix/store/r727rb5g76xzmprli54srrhklxbpyr0x-stdenv-linux.drv' failed

@oxij
Copy link
Member Author

oxij commented Aug 8, 2018 via email

@Ericson2314 Ericson2314 merged commit fe68c9d into NixOS:staging Aug 8, 2018
@Ericson2314
Copy link
Member

I didn't know if you wanted to merge them yourself / any further testing.

@oxij
Copy link
Member Author

oxij commented Aug 8, 2018 via email

@oxij oxij mentioned this pull request Aug 18, 2018
Open
@oxij oxij deleted the stdenv/shadows branch November 18, 2018 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ericson2314 Ericson2314

Assignees
No one assigned
Labels
6.topic: stdenv Standard environment 10.rebuild-darwin: 501+ 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild 10.rebuild-linux: 501+ 10.rebuild-linux-stdenv This PR causes stdenv to rebuild
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@oxij @GrahamcOfBorg @Ericson2314