Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cc-wrapper: propagate man and info to propagated-build-inputs #44516

Merged
merged 1 commit into from Aug 5, 2018

Conversation

oxij
Copy link
Member

@oxij oxij commented Aug 5, 2018

Should fix #43547.

@Ericson2314
Copy link
Member

Thanks so much!!

@Ericson2314 Ericson2314 merged commit 8686539 into NixOS:staging Aug 5, 2018
@oxij
Copy link
Member Author

oxij commented Aug 6, 2018 via email

@dezgeg
Copy link
Contributor

dezgeg commented Aug 6, 2018

Does this actually work? I don't think either environment.systemPackages or nix-env -i will follow propagated build inputs.

I think you should be just able to do:

ln -s ${cc.man} $man

@oxij
Copy link
Member Author

oxij commented Aug 6, 2018 via email

@oxij
Copy link
Member Author

oxij commented Aug 6, 2018 via email

@oxij oxij mentioned this pull request Aug 6, 2018
1 task
@oxij
Copy link
Member Author

oxij commented Aug 6, 2018

See #44558.

@Ericson2314
Copy link
Member

I'm sorry. I might has improperly tested that. (Worse, I have some dejavu as if I made the same mistake before.)

In a post-strictDeps world, it would actually make sense to make propagatedBuildInputsdo that, but there's nothing wrong with the symlink thing so let's just do that.

@oxij
Copy link
Member Author

oxij commented Aug 6, 2018

@Ericson2314 Nah, don't mind, breaking things is half the fun after all.

#44558 needs some testing love on Darwin, though.

oxij added a commit to oxij/nixpkgs that referenced this pull request Aug 6, 2018
@dezgeg
Copy link
Contributor

dezgeg commented Aug 7, 2018

But if it's not, then I feel like propagated-user-env-packages makes more sense there semantically

I agree, I also thought propagated-user-env-packages would work. But I guess it's only looked in the main output and not in man or the others.

In a post-strictDeps world, it would actually make sense to make propagatedBuildInputsdo that, but there's nothing wrong with the symlink thing so let's just do that.

Why? propagatedBuildInputs are only intended for building stuff that depends on the package. In multiple-outputs packages they aren't even visible at runtime, because the propagated-build-inputs file only exists in the dev output. Of course this strictDeps thing will never, ever be going to happen for native compilation so it's a moot point, but anyway...

@Ericson2314
Copy link
Member

You said it yourself; it isn't used on things people want to install anyways. propagatedBuildInputs, rightly used, is basically only for libraries that rely on other libraries. It wouldn't be used by things people install anyways, even if it weren't for multiple outputs.

OTOH, if you manually install a dev output, I don't see why you shouldn't get the propagated deps too. Otherwise, the headers are useless.

@dezgeg
Copy link
Contributor

dezgeg commented Aug 7, 2018

Manually installing .dev outputs isn't going to work anyway because setup hooks won't be run. It's just not supported (currently).

@oxij oxij deleted the pkg/fix-cc-wrapper-doc branch November 18, 2018 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants