Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.fire: init at 0.1.3 #44493

Merged
merged 1 commit into from Aug 6, 2018
Merged

pythonPackages.fire: init at 0.1.3 #44493

merged 1 commit into from Aug 6, 2018

Conversation

leenaars
Copy link
Contributor

@leenaars leenaars commented Aug 5, 2018

Motivation for this change

Useful library.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@leenaars leenaars requested a review from FRidh as a code owner August 5, 2018 08:09
@leenaars leenaars changed the title pythonPackages.fire: init -> 0.1.3 pythonPackages.fire: init at 0.1.3 Aug 5, 2018
dotlambda
dotlambda reviewed Aug 5, 2018
View reviewed changes
pkgs/top-level/python-packages.nix Outdated
@@ -17597,6 +17597,8 @@ EOF

simpy = callPackage ../development/python-modules/simpy { };

fire = callPackage ../development/python-modules/fire { };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should be ordered alphabetically.

Copy link
Contributor Author

@leenaars leenaars Aug 6, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reviewing!

That file is actually so chaotic and long that one would be inclined to find another ordering mechanism. The alphabetic order is too broken. Search is the only reasonable way of finding anything in thousands of lines, and that is probably how everyone finds their stuff. So adding new modules at the end seems just as reasonable. But of course there is nothing against alphabetic ordering...

I've swapped it somewhere where it seems more alphabetic...

@dotlambda
Copy link
Member

@GrahamcOfBorg build python2.pkgs.fire python3.pkgs.fire

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python2.pkgs.fire, python3.pkgs.fire

Partial log (click to expand)

fire/inspectutils_test.py .........                                      [ 73%]
fire/interact_test.py ..                                                 [ 75%]
fire/parser_test.py ....................                                 [ 87%]
fire/test_components_test.py ..                                          [ 88%]
fire/testutils_test.py ...                                               [ 90%]
fire/trace_test.py ...............                                       [100%]

========================== 160 passed in 0.95 seconds ==========================
/nix/store/p04vwpbvfzgbm90hchkqyvziylijvwdm-python2.7-fire-0.1.3
/nix/store/zzb2p52i50rhrq4smvfmcpnpj6gfyhb9-python3.6-fire-0.1.3

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python2.pkgs.fire, python3.pkgs.fire

Partial log (click to expand)

fire/inspectutils_test.py .........                                      [ 73%]
fire/interact_test.py ..                                                 [ 75%]
fire/parser_test.py ....................                                 [ 87%]
fire/test_components_test.py ..                                          [ 88%]
fire/testutils_test.py ...                                               [ 90%]
fire/trace_test.py ...............                                       [100%]

========================== 160 passed in 5.80 seconds ==========================
/nix/store/72hm611qi10qmhps0lxihl842k84nd9v-python2.7-fire-0.1.3
/nix/store/kbi1w6p2a05bpbj9dlyjhq6w27yq4lsy-python3.6-fire-0.1.3

@dotlambda dotlambda merged commit 040bbfa into NixOS:master Aug 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@leenaars @dotlambda @GrahamcOfBorg