Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cddlib: 0.94i -> 0.94j #44508

Merged
merged 1 commit into from Aug 5, 2018
Merged

cddlib: 0.94i -> 0.94j #44508

merged 1 commit into from Aug 5, 2018

Conversation

timokau
Copy link
Member

@timokau timokau commented Aug 5, 2018

Motivation for this change

cddlib was autotoolized, incorporated equivalents to the sage patches
and moved to GitHub.

The build is simplified, I added myself as a maintainer and asked for tests upstream.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@timokau
Copy link
Member Author

timokau commented Aug 5, 2018

@GrahamcOfBorg build sage

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: sage

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: sage

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: cddlib

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: cddlib

Partial log (click to expand)

shrinking /nix/store/sbnhqkz731402kfzwf8l7g1bxsrls7ny-cddlib-0.94j/bin/cddexec_gmp
shrinking /nix/store/sbnhqkz731402kfzwf8l7g1bxsrls7ny-cddlib-0.94j/bin/fourier
shrinking /nix/store/sbnhqkz731402kfzwf8l7g1bxsrls7ny-cddlib-0.94j/bin/testcdd2
shrinking /nix/store/sbnhqkz731402kfzwf8l7g1bxsrls7ny-cddlib-0.94j/bin/testlp1
shrinking /nix/store/sbnhqkz731402kfzwf8l7g1bxsrls7ny-cddlib-0.94j/bin/testlp2
strip is /nix/store/1hi76hr87bd1y1q1qjk0lv8nmcjip1c8-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/sbnhqkz731402kfzwf8l7g1bxsrls7ny-cddlib-0.94j/lib  /nix/store/sbnhqkz731402kfzwf8l7g1bxsrls7ny-cddlib-0.94j/bin
patching script interpreter paths in /nix/store/sbnhqkz731402kfzwf8l7g1bxsrls7ny-cddlib-0.94j
checking for references to /build in /nix/store/sbnhqkz731402kfzwf8l7g1bxsrls7ny-cddlib-0.94j...
/nix/store/sbnhqkz731402kfzwf8l7g1bxsrls7ny-cddlib-0.94j

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: cddlib

Partial log (click to expand)

shrinking /nix/store/9vg71444jax02bqdb59dffv12fyw3kgs-cddlib-0.94j/bin/redcheck
shrinking /nix/store/9vg71444jax02bqdb59dffv12fyw3kgs-cddlib-0.94j/bin/lcdd
shrinking /nix/store/9vg71444jax02bqdb59dffv12fyw3kgs-cddlib-0.94j/bin/scdd
shrinking /nix/store/9vg71444jax02bqdb59dffv12fyw3kgs-cddlib-0.94j/lib/libcddgmp.so.0.0.0
shrinking /nix/store/9vg71444jax02bqdb59dffv12fyw3kgs-cddlib-0.94j/lib/libcdd.so.0.0.0
strip is /nix/store/zrs21zqcchgyabjf4xfimncdq16njizc-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/9vg71444jax02bqdb59dffv12fyw3kgs-cddlib-0.94j/lib  /nix/store/9vg71444jax02bqdb59dffv12fyw3kgs-cddlib-0.94j/bin
patching script interpreter paths in /nix/store/9vg71444jax02bqdb59dffv12fyw3kgs-cddlib-0.94j
checking for references to /build in /nix/store/9vg71444jax02bqdb59dffv12fyw3kgs-cddlib-0.94j...
/nix/store/9vg71444jax02bqdb59dffv12fyw3kgs-cddlib-0.94j

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: sage

Partial log (click to expand)

    [774 tests, 475.67 s]
----------------------------------------------------------------------
sage -t --long /nix/store/qxvr1y5pf5v1qlby7zwwmi69y6h28p90-sage-src-8.3/src/doc/en/thematic_tutorials/geometry/polyhedra_tutorial.rst  # 3 doctests failed
----------------------------------------------------------------------
Total time for all tests: 2520.6 seconds
    cpu time: 15799.6 seconds
    cumulative wall time: 18699.6 seconds
builder for '/nix/store/pda5b9wippazqbs67lacc18h2ghk6hp6-sage-8.3.drv' failed with exit code 1
cannot build derivation '/nix/store/85yxas14pkrj4ashsxm9bcxyfp9q9112-sage-wrapper-8.3.drv': 1 dependencies couldn't be built
error: build of '/nix/store/85yxas14pkrj4ashsxm9bcxyfp9q9112-sage-wrapper-8.3.drv' failed

@timokau timokau changed the title cddlib: 0.94i -> 0.94j [WIP] cddlib: 0.94i -> 0.94j Aug 5, 2018
@timokau
Copy link
Member Author

timokau commented Aug 5, 2018

Hm I did this update a while ago and then forgot about this branch. I'm pretty sure tests passed, maybe something went wrong with the rebase.

@timokau
cddlib: 0.94i -> 0.94j
0a44ff7 
cddlib was autotoolized, incorporated equivalents to the sage patches
and moved to GitHub.
@timokau
Copy link
Member Author

timokau commented Aug 5, 2018

Turns out I explicitly excluded the file with the missing test from the sage patch. I created the branch before the 8.3 update and the file didn't exist in 8.2. My bad.

@GrahamcOfBorg build sage

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: sage

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: sage

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: sage

Partial log (click to expand)

configuring
building
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/ddghdxh8ak6qrmbs40gipkj3w6x38d79-sage-wrapper-8.3
strip is /nix/store/1hi76hr87bd1y1q1qjk0lv8nmcjip1c8-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/ddghdxh8ak6qrmbs40gipkj3w6x38d79-sage-wrapper-8.3/bin
patching script interpreter paths in /nix/store/ddghdxh8ak6qrmbs40gipkj3w6x38d79-sage-wrapper-8.3
checking for references to /build in /nix/store/ddghdxh8ak6qrmbs40gipkj3w6x38d79-sage-wrapper-8.3...
/nix/store/ddghdxh8ak6qrmbs40gipkj3w6x38d79-sage-wrapper-8.3

@timokau timokau changed the title [WIP] cddlib: 0.94i -> 0.94j cddlib: 0.94i -> 0.94j Aug 5, 2018
@timokau
Copy link
Member Author

timokau commented Aug 5, 2018

CC @7c6f434c

@7c6f434c 7c6f434c merged commit 75cb046 into NixOS:master Aug 5, 2018
@timokau timokau deleted the cddlib-0.94j branch August 6, 2018 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: work-in-progress 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@timokau @GrahamcOfBorg @pSub @7c6f434c