Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use LLVM 6 with llvm-hs, don't run tests on Darwin. #44468

Merged
merged 1 commit into from Aug 5, 2018
Merged

Use LLVM 6 with llvm-hs, don't run tests on Darwin. #44468

merged 1 commit into from Aug 5, 2018

Conversation

TravisWhitaker
Copy link
Contributor

@TravisWhitaker TravisWhitaker commented Aug 4, 2018 •
edited

Motivation for this change

Fixes llvm-hs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added 6.topic: darwin Running or building packages on Darwin 6.topic: haskell labels Aug 4, 2018
ryantm
ryantm requested changes Aug 4, 2018
View reviewed changes
Copy link
Member

@ryantm ryantm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please change the commit message to match the contributing guidelines? I think it should be something like haskellPackages.llvm-hs: use llvm 6, don't run tests on darwin. Also currently OfBorg says this doesn't evaluate, so please take a look at that.

@ryantm
Copy link
Member

ryantm commented Aug 5, 2018

@GrahamcOfBorg build haskellPackages.llvm-hs

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: haskellPackages.llvm-hs

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: haskellPackages.llvm-hs

Partial log (click to expand)

dist/doc/html/llvm-hs/llvm-hs.txt
installing
Installing library in /nix/store/2yf3zwwigl63yhx7aprwi421a8183w3j-llvm-hs-6.3.0/lib/ghc-8.4.3/llvm-hs-6.3.0
post-installation fixup
strip is /nix/store/qfxcr8c4fg7lkybrny9n2sb77bmippdx-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/2yf3zwwigl63yhx7aprwi421a8183w3j-llvm-hs-6.3.0/lib
patching script interpreter paths in /nix/store/2yf3zwwigl63yhx7aprwi421a8183w3j-llvm-hs-6.3.0
strip is /nix/store/qfxcr8c4fg7lkybrny9n2sb77bmippdx-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/12niszdnyrbczmh0lzgjyc459waid80d-llvm-hs-6.3.0-doc
/nix/store/2yf3zwwigl63yhx7aprwi421a8183w3j-llvm-hs-6.3.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: haskellPackages.llvm-hs

Partial log (click to expand)

strip is /nix/store/1hi76hr87bd1y1q1qjk0lv8nmcjip1c8-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/5zdkwbayrnp85cnif9cpya92yzh65ilv-llvm-hs-6.3.0/lib
patching script interpreter paths in /nix/store/5zdkwbayrnp85cnif9cpya92yzh65ilv-llvm-hs-6.3.0
checking for references to /build in /nix/store/5zdkwbayrnp85cnif9cpya92yzh65ilv-llvm-hs-6.3.0...
wrong ELF type
shrinking RPATHs of ELF executables and libraries in /nix/store/wxr8r9rkwd6jdzccpxxgjdpnq2a27ppl-llvm-hs-6.3.0-doc
strip is /nix/store/1hi76hr87bd1y1q1qjk0lv8nmcjip1c8-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/wxr8r9rkwd6jdzccpxxgjdpnq2a27ppl-llvm-hs-6.3.0-doc
checking for references to /build in /nix/store/wxr8r9rkwd6jdzccpxxgjdpnq2a27ppl-llvm-hs-6.3.0-doc...
/nix/store/5zdkwbayrnp85cnif9cpya92yzh65ilv-llvm-hs-6.3.0

@ryantm ryantm merged commit a3e7fc8 into NixOS:master Aug 5, 2018
@ryantm
Copy link
Member

ryantm commented Aug 5, 2018

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantm ryantm ryantm approved these changes

@basvandijk basvandijk Awaiting requested review from basvandijk

@peti peti Awaiting requested review from peti

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: haskell 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@TravisWhitaker @ryantm @GrahamcOfBorg