Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

php: 5.6.36 -> 5.6.37, 7.0.30 -> 7.0.31 #44525

Merged
merged 2 commits into from Aug 6, 2018
Merged

php: 5.6.36 -> 5.6.37, 7.0.30 -> 7.0.31 #44525

merged 2 commits into from Aug 6, 2018

Conversation

etu
Copy link
Contributor

@etu etu commented Aug 5, 2018

Motivation for this change

These versions are not in master, but we should still keep stable patched with security fixes 馃槃

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

cc @globin

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: php56, php70

Partial log (click to expand)

/nix/store/avyd2spawkgkm1l747jvw05wiw7bjcb0-php-7.0.31/bin/php-config: interpreter directive changed from " /bin/sh" to "/nix/store/i7pgaclm3qrcm9gpqxb5mbw9wsn7prd0-bash-4.4-p12/bin/sh"
/nix/store/avyd2spawkgkm1l747jvw05wiw7bjcb0-php-7.0.31/bin/phpize: interpreter directive changed from "/bin/sh" to "/nix/store/i7pgaclm3qrcm9gpqxb5mbw9wsn7prd0-bash-4.4-p12/bin/sh"
checking for references to /build in /nix/store/avyd2spawkgkm1l747jvw05wiw7bjcb0-php-7.0.31...
moving /nix/store/avyd2spawkgkm1l747jvw05wiw7bjcb0-php-7.0.31/sbin/* to /nix/store/avyd2spawkgkm1l747jvw05wiw7bjcb0-php-7.0.31/bin
shrinking RPATHs of ELF executables and libraries in /nix/store/xp30y715s80sls7w1m4lwf74hhaqnfn1-php-7.0.31-dev
strip is /nix/store/hy39vplmzpwckvzxgyhr54dwz0mnfv2p-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/xp30y715s80sls7w1m4lwf74hhaqnfn1-php-7.0.31-dev
checking for references to /build in /nix/store/xp30y715s80sls7w1m4lwf74hhaqnfn1-php-7.0.31-dev...
/nix/store/cspknnyawamh345pw3l4nipc1bz93i73-php-5.6.37
/nix/store/avyd2spawkgkm1l747jvw05wiw7bjcb0-php-7.0.31

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: php56, php70

Partial log (click to expand)

/nix/store/gwwmmcipzvbdqp7spi7h04h3vfn8bamx-php-7.0.31/bin/php-config: interpreter directive changed from " /bin/sh" to "/nix/store/lw7xaqhakk0i1c631m3cvac3x4lc5gr5-bash-4.4-p12/bin/sh"
/nix/store/gwwmmcipzvbdqp7spi7h04h3vfn8bamx-php-7.0.31/bin/phpize: interpreter directive changed from "/bin/sh" to "/nix/store/lw7xaqhakk0i1c631m3cvac3x4lc5gr5-bash-4.4-p12/bin/sh"
checking for references to /build in /nix/store/gwwmmcipzvbdqp7spi7h04h3vfn8bamx-php-7.0.31...
moving /nix/store/gwwmmcipzvbdqp7spi7h04h3vfn8bamx-php-7.0.31/sbin/* to /nix/store/gwwmmcipzvbdqp7spi7h04h3vfn8bamx-php-7.0.31/bin
shrinking RPATHs of ELF executables and libraries in /nix/store/ynmdbpidanykdnfy57g4nnfzkdxhg51n-php-7.0.31-dev
strip is /nix/store/k8b9hqv58dd1z0j4ikak24ykndcm91s6-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/ynmdbpidanykdnfy57g4nnfzkdxhg51n-php-7.0.31-dev
checking for references to /build in /nix/store/ynmdbpidanykdnfy57g4nnfzkdxhg51n-php-7.0.31-dev...
/nix/store/1dfi0s4d2vrjag5y5gciw6c6al017b4v-php-5.6.37
/nix/store/gwwmmcipzvbdqp7spi7h04h3vfn8bamx-php-7.0.31

@adisbladis adisbladis merged commit 6b244a4 into NixOS:release-18.03 Aug 6, 2018
@etu etu deleted the 1803-php-upgrades branch August 6, 2018 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@etu @GrahamcOfBorg @adisbladis