Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sage: don't override pari #44501

Merged
merged 1 commit into from Aug 5, 2018
Merged

sage: don't override pari #44501

merged 1 commit into from Aug 5, 2018

Conversation

timokau
Copy link
Member

@timokau timokau commented Aug 5, 2018

Motivation for this change

Getting pretty close to the goal of no dependency overrides for sage :)

Sage assumes that pari does not use threads. However instead of
disabling them at compile time, we can diable them at runtime instead.
As a result, sage doesn't need its own version of pari anymore. That
means less rebuilds, less complexity and easier debugging.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@timokau
sage: don't override pari
30c8221 
Sage assumes that pari does not use threads. However instead of
disabling them at compile time, we can diable them at runtime instead.
As a result, sage doesn't need its own version of pari anymore. That
means less rebuilds, less complexity and easier debugging.
@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: sage

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: sage

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: sage

Partial log (click to expand)

configuring
building
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/w1yw5i94j45vv122m81c7nghzpv2x42v-sage-wrapper-8.3
strip is /nix/store/1hi76hr87bd1y1q1qjk0lv8nmcjip1c8-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/w1yw5i94j45vv122m81c7nghzpv2x42v-sage-wrapper-8.3/bin
patching script interpreter paths in /nix/store/w1yw5i94j45vv122m81c7nghzpv2x42v-sage-wrapper-8.3
checking for references to /build in /nix/store/w1yw5i94j45vv122m81c7nghzpv2x42v-sage-wrapper-8.3...
/nix/store/w1yw5i94j45vv122m81c7nghzpv2x42v-sage-wrapper-8.3

@timokau
Copy link
Member Author

timokau commented Aug 5, 2018

So ofBorg can run sage tests now 🎉

@7c6f434c 7c6f434c merged commit 6b02349 into NixOS:master Aug 5, 2018
@timokau timokau deleted the sage-native-pari branch August 5, 2018 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@timokau @GrahamcOfBorg @7c6f434c