Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib/trivial: remove deprecation warning for lib.nixpkgsVersion. #44498

Closed

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Aug 5, 2018

Motivation for this change

Originally introduced in #39416 (1),
however it causes confusion and shouldn't be deprecated (2)(3).

/cc @edolstra

(1) #39416 (comment)
(2) 9274ea3#commitcomment-29951594
(3) NixOS/nix#2291

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Originally introduced in NixOS#39416 (1),
however it causes confusion and shouldn't be deprecated (2)(3).

/cc @edolstra

(1) NixOS#39416 (comment)
(2) NixOS@9274ea3#commitcomment-29951594
(3) NixOS/nix#2291
@xeji
Copy link
Contributor

xeji commented Aug 5, 2018

looks like a duplicate of #44165

@Ma27
Copy link
Member Author

Ma27 commented Aug 5, 2018

didn't see it, was asked by @edolstra to revert it. Closing, thanks for seeing this!

@Ma27 Ma27 closed this Aug 5, 2018
@Ma27 Ma27 deleted the revert-lib.nixpkgsVersion-deprecation branch August 5, 2018 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants