Newtonsoft.Json: 6.0.8 -> 11.0.2 #44478
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this also fixes #44470 |
samueldr
requested changes
Aug 10, 2018
There was a problem hiding this comment.
Thank you for the update!
Is it be possible the first two commits (about vym) and the last commit (about monodevelop) were accidentally added to the branch? They don't seem to be related to Newtonsoft.Json changes. (A rebase would probably get rid of your first stow-away commits.)
Purging them from the branch, then squashing/rebasing to master would be necessary to, then, merge this.
As for the update, it removes a bunch of code (no code is good code), so if it doesn't cause issues elsewhere (to be tested) it'll probably be fine.
When creating a new mobile broadband connection with the plasma network manager connection editor, it tries to find a file containing provider information somewhere in /usr/share/... . The build recipe contains a patch to fix the lookup path such that it finds the file in the corresponding package, probably added due to #9389 . The actual lookup path is injected into the patch file with substituteAll. With commit a31d98f , the variable name used in subsituteAll changed from mobile_broadband_provider_info to mobile-broadband-provider-info (underscores in package names turned into dashes). Apparently, substituteAll can't handle dashes in variable names. Consequently, the variable name was no longer resolved. plasma-nm failed to create new mobile broadband connections; the connection creator silently exited and logged the error > plasma-nm: Error opening providers file "@mobile-broadband-provider-info@/share/mobile-broadband-provider-info/serviceproviders.xml" This commit keeps the dashes in package names, but it restores the underscores in the variable used by substituteAll, thereby ensuring the variable gets resolved properly.
Until now it's impossible to override the attrs of the actual build
instruction for the `termite` package like this:
```
termite.overrideAttrs (_: {
# ...
})
```
This issue occurs since the `termite/default.nix` expressions returns
the `symlinkJoin` expression when I override termite (e.g. to provide a
config file).
I recently patched termite and wanted to apply this patch to my local
termite installation in my system config which is impossible this, so
splitting the wrapper and the build instruction into their own files
makes this way easier to maintian.
The latest binutils upgrade silently broke this until it was fixed by #43531. So add a test.
GrahamcOfBorg
added
6.topic: emacs
6.topic: erlang
6.topic: fetch
6.topic: GNOME
|
sry, something went awry... |
|
Does this fix the original issue though? We can just cherrypick c632384 if so. |
|
yes, it fixes the original issue. |
9 tasks
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Package was outdated and needed for OpenRA.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)