Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

renderdoc: 1.0 -> 1.1 #44474

Merged
merged 1 commit into from Aug 4, 2018
Merged

renderdoc: 1.0 -> 1.1 #44474

merged 1 commit into from Aug 4, 2018

Conversation

Ralith
Copy link
Contributor

@Ralith Ralith commented Aug 4, 2018

Motivation for this change

Bugfixes

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Aug 4, 2018

@GrahamcOfBorg build renderdoc

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: renderdoc

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: renderdoc

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: renderdoc

Partial log (click to expand)

compiling ../../qrenderdoc/Windows/TimelineBar.cpp
compiling ../../qrenderdoc/Windows/Dialogs/SettingsDialog.cpp
compiling ../../qrenderdoc/Widgets/OrderedListEditor.cpp
compiling ../../qrenderdoc/Widgets/Extended/RDTableWidget.cpp
compiling ../../qrenderdoc/Windows/Dialogs/SuggestRemoteDialog.cpp
compiling ../../qrenderdoc/Windows/Dialogs/VirtualFileDialog.cpp
compiling ../../qrenderdoc/Windows/Dialogs/RemoteManager.cpp
compiling ../../qrenderdoc/Windows/PixelHistoryView.cpp
building of '/nix/store/36l8zbpynb2za3q0566az0f23jap1qvr-renderdoc-1.1.drv' timed out after 3600 seconds
error: build of '/nix/store/36l8zbpynb2za3q0566az0f23jap1qvr-renderdoc-1.1.drv' failed

@Ralith
Copy link
Contributor Author

Ralith commented Aug 4, 2018

Seems spurious. It's a pretty big build, with some big bundled dependencies.

@xeji
Copy link
Contributor

xeji commented Aug 4, 2018

Yes, currently some Qt stuff is being rebuilt and causes timeouts on ofborg. I built the package locally, LGTM.

@xeji xeji merged commit 606a260 into NixOS:master Aug 4, 2018
@Ralith Ralith deleted the renderdoc branch August 4, 2018 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ralith @xeji @GrahamcOfBorg