Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mdbook: 0.1.8 -> 0.2.0 #44494

Closed
wants to merge 1 commit into from
Closed

mdbook: 0.1.8 -> 0.2.0 #44494

wants to merge 1 commit into from

Conversation

dywedir
Copy link
Member

@dywedir dywedir commented Aug 5, 2018

https://github.com/rust-lang-nursery/mdBook/releases/tag/v0.2.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

cc @Havvy

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: mdbook

Partial log (click to expand)


installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/agm6zc3l7kcbly6nfgqs1mwzl4xl8g6j-mdbook-0.2.0
shrinking /nix/store/agm6zc3l7kcbly6nfgqs1mwzl4xl8g6j-mdbook-0.2.0/bin/mdbook
strip is /nix/store/zrs21zqcchgyabjf4xfimncdq16njizc-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/agm6zc3l7kcbly6nfgqs1mwzl4xl8g6j-mdbook-0.2.0/bin
patching script interpreter paths in /nix/store/agm6zc3l7kcbly6nfgqs1mwzl4xl8g6j-mdbook-0.2.0
checking for references to /build in /nix/store/agm6zc3l7kcbly6nfgqs1mwzl4xl8g6j-mdbook-0.2.0...
/nix/store/agm6zc3l7kcbly6nfgqs1mwzl4xl8g6j-mdbook-0.2.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: mdbook

Partial log (click to expand)


installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/bjzs43916rdnnsg0875yk4m5qlz8m79p-mdbook-0.2.0
shrinking /nix/store/bjzs43916rdnnsg0875yk4m5qlz8m79p-mdbook-0.2.0/bin/mdbook
strip is /nix/store/1hi76hr87bd1y1q1qjk0lv8nmcjip1c8-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/bjzs43916rdnnsg0875yk4m5qlz8m79p-mdbook-0.2.0/bin
patching script interpreter paths in /nix/store/bjzs43916rdnnsg0875yk4m5qlz8m79p-mdbook-0.2.0
checking for references to /build in /nix/store/bjzs43916rdnnsg0875yk4m5qlz8m79p-mdbook-0.2.0...
/nix/store/bjzs43916rdnnsg0875yk4m5qlz8m79p-mdbook-0.2.0

@Havvy
Copy link
Contributor

Havvy commented Aug 5, 2018

You're gonna want to keep at least 0.1.8 until we can get all the links updated in the Rust books.

@Mic92
Copy link
Member

Mic92 commented Aug 5, 2018

Is there a way to find out, when this happen (like an issue?).

@Havvy
Copy link
Contributor

Havvy commented Aug 21, 2018

I've a tracking issue at rust-docs/team#23

@cw789
Copy link
Contributor

cw789 commented May 23, 2019

v0.2.3 is the latest now ...

It's not good for the nix pkgs ecosystem, that updates are hold back by such circumstances.
Should be solved by pinning nix pkgs or some other solutions ...

@tazjin
Copy link
Member

tazjin commented Aug 4, 2019

I opened #65890 to move this to 0.3.1 (which is the latest version).

Agree with @cw789 that external projects depending on an old version via Nix should look to pin that version separately.

@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/50

@samueldr samueldr mentioned this pull request Aug 5, 2019
Merged
10 tasks
@dywedir dywedir deleted the mdbook branch August 12, 2019 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@dywedir @GrahamcOfBorg @Havvy @Mic92 @cw789 @tazjin @nixos-discourse @infinisil @worldofpeace