Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tex-gyre: remove unused displayName argument #44513

Merged
merged 1 commit into from Aug 5, 2018
Merged

tex-gyre: remove unused displayName argument #44513

merged 1 commit into from Aug 5, 2018

Conversation

ttuegel
Copy link
Member

@ttuegel ttuegel commented Aug 5, 2018

Motivation

Fixes evaluation of tex-gyre.

Testing

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@vcunat
Copy link
Member

vcunat commented Aug 5, 2018

I suspect this is used by tex-gyre-math. Some half-automatic cleanups were not completely without regressions /cc @volth 52f53c6.

@ttuegel
Copy link
Member Author

ttuegel commented Aug 5, 2018

I suspect this is used by tex-gyre-math.

It doesn't seem to be used by tex-gyre-math...

@ttuegel ttuegel merged commit 4460f72 into NixOS:master Aug 5, 2018
@jtojnar
Copy link
Contributor

jtojnar commented Aug 5, 2018

Hmm, I think the display name was supposed to be used in meta.description or something.

@vcunat
Copy link
Member

vcunat commented Aug 6, 2018

Well, tex-gyre-math uses displayName attributes for meta.longDescription, but apparently only for displayName attributes defined in its own file, so this PR should be OK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ttuegel @vcunat @jtojnar @GrahamcOfBorg