detect timedout builds #206
Merged
+229
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the commentposter to handle other build statuses like a timeout. The BuildResult struct still includes success and the commentposter can still handle messages in the old format for backwards compatibility.
grahamc
reviewed
Aug 7, 2018
| assert_eq!(lines, vec!["stdout", "stderr", "stdout2", "stderr2"]); | ||
| let ret = spawned.wait().unwrap().unwrap().unwrap().success(); |
LnL7
commented
Aug 7, 2018
| }, | ||
| }, | ||
| e => BuildStatus::UnexpectedError { | ||
| err: format!("failed on interior command {:?}", e), |
There was a problem hiding this comment.
I don't think it's a problem in practice, but this could potentially expose more information about the builder then before.
LnL7
commented
Aug 7, 2018
| self.waiter.join() | ||
| .map_err(|_err| io::Error::new(io::ErrorKind::Other, "Couldn't join thread.")) | ||
| .and_then(|opt| opt.ok_or(io::Error::new(io::ErrorKind::Other, "Thread didn't return an exit status."))) |
There was a problem hiding this comment.
I'm not entirely sure these messages are correct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should change the error messages for timed out builds to something like.
I think this is fully backwards compatible, allowing builders to continue sending build results in the old format, while newer versions send more information using the new format. This could be cleaned up once all the infrastructure is updated.