Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

greenclip: 2.0.1 -> 3.0.2 #43891

Closed
wants to merge 1 commit into from
Closed

greenclip: 2.0.1 -> 3.0.2 #43891

wants to merge 1 commit into from

Conversation

Tomahna
Copy link
Contributor

@Tomahna Tomahna commented Jul 21, 2018

Motivation for this change

#43684
https://github.com/erebe/greenclip/issues/35

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Tomahna Tomahna requested a review from peti as a code owner July 21, 2018 14:00
@infinisil
Copy link
Member

This file is auto-generated btw, it might still be okay though

peti
peti requested changes Jul 21, 2018
View reviewed changes
Copy link
Member

@peti peti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is generated automatically. Please do not edit it; all you changes will be lost. Note the comment at the top.

@Tomahna
Copy link
Contributor Author

Tomahna commented Jul 21, 2018

Okay. Is there an action required to upgrade the package then ?

@Tomahna Tomahna closed this Jul 21, 2018
@Tomahna Tomahna deleted the greenclip branch July 21, 2018 14:07
@peti
Copy link
Member

peti commented Jul 21, 2018

No action is required. The new version will appear in master in a few hours.

@kalbasit
Copy link
Member

greenclip got updated on master, but it's still failing for me

Preprocessing library for wordexp-0.2.0.0..
Building library for wordexp-0.2.0.0..
[1 of 2] Compiling System.Wordexp   ( dist/build/System/Wordexp.hs, dist/build/System/Wordexp.o )

src/System/Wordexp.chs:26:39: error:
    Module ‘Data.Semigroup’ does not export ‘Monoid(..)’
   |
26 | #include <wordexp.h>
   |                                       ^^^^^^^^^^
builder for '/nix/store/hnrazwnxmawfzmqj7wjaka0jg4wr890n-wordexp-0.2.0.0.drv' failed with exit code 1
cannot build derivation '/nix/store/m4zdmqbcy9llrcdipm68j8mrkys1wl2z-greenclip-3.0.2.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/ch9lsibwbdlm4azyfb09l2adjd9x6x63-i3-config.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/6m1yychpv1hznv6qrbwcbfyc6m9dq3ck-all.drv': 1 dependencies couldn't be built
error: build of '/nix/store/6m1yychpv1hznv6qrbwcbfyc6m9dq3ck-all.drv' failed

@peti
Copy link
Member

peti commented Jul 22, 2018

That is a different error. wordexp-0.2.0.0 does not compile. I'd guess it has trouble coping with ghc 8.4.3. It's probably best to report that issue to upstream, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti peti requested changes

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Tomahna @infinisil @peti @kalbasit @GrahamcOfBorg