Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rshell: init at 0.0.14 #43881

Merged
merged 1 commit into from Jul 26, 2018
Merged

rshell: init at 0.0.14 #43881

merged 1 commit into from Jul 26, 2018

Conversation

c0deaddict
Copy link
Member

Motivation for this change

Package is not nixpkgs yet.

Things done

Added rshell python application.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@c0deaddict c0deaddict changed the title rshell: 0.0.14 rshell: init at 0.0.14 Jul 21, 2018
@ryantm
Copy link
Member

ryantm commented Jul 25, 2018

Are you willing to add yourself as a maintainer of this package? To do this, first add yourself to the maintainers list wither your GitHub username as the attr name, then add maintainers = with maintainers; [ YOUR_GITHUB_USERNAME ]; to the meta attrset of the package.

@c0deaddict
Copy link
Member Author

What are the responsibilities of maintainers?

@ryantm
Copy link
Member

ryantm commented Jul 25, 2018

The main responsibilities are to review and test changes to the package and help keep the package up to date.

@c0deaddict
Copy link
Member Author

c0deaddict commented Jul 25, 2018 •
edited

Ok, I can do that :) Added myself as maintainer.

ryantm
ryantm reviewed Jul 26, 2018
View reviewed changes
pkgs/development/tools/rshell/default.nix Outdated

meta = with lib; {
homepage = https://github.com/dhylands/rshell;
description = "Remote Shell for MicroPython ";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an extra space here in the description.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed it.

@ryantm
Copy link
Member

ryantm commented Jul 26, 2018

@GrahamcOfBorg build rshell

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: rshell

Partial log (click to expand)

reading manifest template 'MANIFEST.in'
warning: no files found matching 'tests/test-rshell.shr'
writing manifest file 'rshell.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/6fc1gdkfy4r4dbj0xg7l9lrar3qhb2dj-rshell-0.0.14

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: rshell

Partial log (click to expand)

reading manifest template 'MANIFEST.in'
warning: no files found matching 'tests/test-rshell.shr'
writing manifest file 'rshell.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/1i24nzajirab90n1kmxh7pkaldg0lvg4-rshell-0.0.14

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: rshell

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@ryantm ryantm merged commit 812f474 into NixOS:master Jul 26, 2018
@ryantm
Copy link
Member

ryantm commented Jul 26, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantm ryantm ryantm left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@c0deaddict @ryantm @GrahamcOfBorg