Fix docs navigator not scrolling into open type on page load #6420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ling to it on page load
soanvig
changed the title
|
You can take a look at https://crystal-lang.org/api/0.24.1/ to see it working before. It didn't actually scroll the current element to top but preserved the previous viewport. I think that's better, but it would need to work with the search results list which has a different view port. |
|
So, is this going to be merged or not? Not sure about the process. |
RX14
approved these changes
Jul 30, 2018
sdogruyol
approved these changes
Aug 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix really annoying issue: browsing through API docs requires constantly scrolling through type navigator.
According to @straight-shoota, this function worked before #5229.
I've created my own implementation of that function. It identifies open item by
.currentclass, and selects last of it (to handle case of nested items).Used function
.scrollIntoView()browser compatibility: https://developer.mozilla.org/en-US/docs/Web/API/Element/scrollIntoViewFunction was tested locally and it works, but one may test by himself.