write_stylus: add desktop icon #43864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
Jul 21, 2018
| @@ -16,6 +17,12 @@ stdenv.mkDerivation rec { | |||
| url = "http://www.styluslabs.com/write/write${version}.tar.gz"; | |||
| sha256 = "1p6glp4vdpwl8hmhypayc4cvs3j9jfmjfhhrgqm2xkgl5bfbv2qd"; | |||
| }; | |||
|
|
|||
| icon = fetchurl { | |||
| url = "https://oyra.eu/write/icon.tar.gz"; | |||
There was a problem hiding this comment.
What is the license of this file? Is it your own creation or what is the origin?
There was a problem hiding this comment.
License: Free for commercial use
Downloaded from https://www.iconfinder.com/icons/50835/edit_pencil_write_icon
There was a problem hiding this comment.
Remember not to change/remove this file.
There was a problem hiding this comment.
Remember not to change/remove this file.
tl;dr
the file was removed and the package is uninstallable now...
There was a problem hiding this comment.
True, it's on my todo list but i haven't found the time yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Write has no icons on its own, that's why I have added a freely available icon. Also I fixed a typo.
Motivation for this change
I didn't like that write didn't have an icon in the application launcher.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)