Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build of haskell.packages.ghc822.tensorflow #43867

Closed
wants to merge 3 commits into from
Closed

Fix build of haskell.packages.ghc822.tensorflow #43867

wants to merge 3 commits into from

Conversation

basvandijk
Copy link
Member

Motivation for this change

haskell.packages.ghc822.tensorflow currently fails to build. This fixes that.

@peti this requires a newly generated hackage-packages.nix with NixOS/cabal2nix#361.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@basvandijk basvandijk requested a review from peti as a code owner July 21, 2018 00:31
@basvandijk basvandijk mentioned this pull request Jul 21, 2018
Merged
@peti peti closed this Jul 21, 2018
@peti
Copy link
Member

peti commented Jul 21, 2018

Merged to haskell-updates in 42ad01f6edd66d30400ae4aae6275ea06b9cc01c, 827cec8988a5747b6b6d9a6758442eed64c48efe, and 572bbf910622b38a58e6d3814603b4f8b5b3fa6f. I'll merge to master once the test builds are done.

@peti
Copy link
Member

peti commented Jul 21, 2018

Is https://hydra.nixos.org/eval/1470110#tabs-new something to worry about?

@basvandijk
Copy link
Member Author

I believe tensorflow failed to build on GHC-8.4. However that was with the last published version on Hackage. I had to switch to HEAD to get the package to build on GHC-8.2. I didn't try building HEAD with GHC-8 4. I will do some more tests and see if my overrides can be generalized to configuration-common.nix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti Awaiting requested review from peti

Assignees
No one assigned
Labels
6.topic: haskell 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@basvandijk @peti @GrahamcOfBorg