Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.plaid-python: 2.3.0 -> 2.3.3 #43905

Merged
merged 1 commit into from Jul 21, 2018
Merged

pythonPackages.plaid-python: 2.3.0 -> 2.3.3 #43905

merged 1 commit into from Jul 21, 2018

Conversation

bhipple
Copy link
Contributor

@bhipple bhipple commented Jul 21, 2018 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@bhipple bhipple requested a review from FRidh as a code owner July 21, 2018 16:41
@bhipple
Copy link
Contributor Author

bhipple commented Jul 21, 2018

@GrahamcOfBorg build python2Packages.plaid-python python3Packages.plaid-python

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python2Packages.plaid-python, python3Packages.plaid-python

Partial log (click to expand)

============================= test session starts ==============================
platform linux -- Python 3.6.6, pytest-3.6.2, py-1.5.3, pluggy-0.6.0
rootdir: /build/plaid-python-2.3.3, inifile:
collected 1 item

tests/unit/test_errors.py .                                              [100%]

=========================== 1 passed in 1.04 seconds ===========================
/nix/store/5gvd2vsc5x48la5yka1d4a0dlshfh304-python2.7-plaid-python-2.3.3
/nix/store/z6v60ismdrqn1g4c04x5ppj80119y2my-python3.6-plaid-python-2.3.3

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python2Packages.plaid-python, python3Packages.plaid-python

Partial log (click to expand)

============================= test session starts ==============================
platform linux2 -- Python 2.7.15, pytest-3.6.2, py-1.5.3, pluggy-0.6.0
rootdir: /build/plaid-python-2.3.3, inifile:
collected 1 item

tests/unit/test_errors.py .                                              [100%]

=========================== 1 passed in 8.57 seconds ===========================
/nix/store/1q358fvk45rq9s9k0a3zyfnp0y5gjiam-python2.7-plaid-python-2.3.3
/nix/store/8fv82g5xymkw1v9kpsyx2mn10qzhx34r-python3.6-plaid-python-2.3.3

@dotlambda dotlambda merged commit bc4c0c4 into NixOS:master Jul 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bhipple @GrahamcOfBorg @dotlambda