Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optional static libraries for krb5 and openssl #43870

Merged
merged 2 commits into from Jul 23, 2018
Merged

Optional static libraries for krb5 and openssl #43870

merged 2 commits into from Jul 23, 2018

Conversation

nh2
Copy link
Contributor

@nh2 nh2 commented Jul 21, 2018

Motivation for this change

#43795

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

CC @dtzWill @angerman

nh2 added 2 commits July 21, 2018 04:43
@nh2
krb5: Add staticOnly flag
bc6cfb4
@nh2
openssl: Add static flag.
479dcc3 
Its effect on `postInstall` is carefully written to not
cause recompilation in the default case.
matthewbauer
matthewbauer approved these changes Jul 23, 2018
View reviewed changes
Copy link
Member

@matthewbauer matthewbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

I think the next step after all of this is to make a static overlay with all of the different flags enabled. We can maybe get this to build a few things on hydra.

@matthewbauer matthewbauer merged commit 4639d55 into NixOS:master Jul 23, 2018
@nh2
Copy link
Contributor Author

nh2 commented Jul 28, 2018

I think the next step after all of this is to make a static overlay with all of the different flags enabled. We can maybe get this to build a few things on hydra.

Yes! Great idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer matthewbauer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nh2 @matthewbauer @GrahamcOfBorg