Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ipgrep: init at 1.0 #43887

Merged
merged 1 commit into from Aug 1, 2018
Merged

ipgrep: init at 1.0 #43887

merged 1 commit into from Aug 1, 2018

Conversation

leenaars
Copy link
Contributor

Motivation for this change

A very useful utility. Just throw some text file at it, and it will tell you lots of things about the domain names and IP addresses in it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

infinisil
infinisil requested changes Jul 24, 2018
View reviewed changes
pkgs/tools/networking/ipgrep/default.nix Outdated
src = fetchFromGitHub {
owner = "jedisct1";
repo = pname;
rev = "${version}";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rev = version;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

pkgs/tools/networking/ipgrep/default.nix Outdated
sha256 = "1qaxvbqdalvz05aplhhrg7s4h7yx4clbfd50k46bgavhgcqqv8n3";
};

phases = "unpackPhase installPhase fixupPhase";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't assign phases directly, remove that and see what it takes to make it work.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I patched the setup.py file, now it works without defining the phases.

@leenaars leenaars force-pushed the ipgrep branch 2 times, most recently from 92abd48 to 6b88c89 Compare August 1, 2018 00:14
@xeji
Copy link
Contributor

xeji commented Aug 1, 2018

@GrahamcOfBorg build ipgrep

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: ipgrep

Partial log (click to expand)

package init file 'ipgrep/__init__.py' not found (or not a regular file)
reading manifest file 'ipgrep.egg-info/SOURCES.txt'
writing manifest file 'ipgrep.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/k3iwgbarl08zzwwlnzq0h5i98qhlvmn2-ipgrep-1.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: ipgrep

Partial log (click to expand)

package init file 'ipgrep/__init__.py' not found (or not a regular file)
reading manifest file 'ipgrep.egg-info/SOURCES.txt'
writing manifest file 'ipgrep.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/3bp7z15xf6s599w7gn3xsvc1rlz3z2w9-ipgrep-1.0

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: ipgrep

Partial log (click to expand)

package init file 'ipgrep/__init__.py' not found (or not a regular file)
reading manifest file 'ipgrep.egg-info/SOURCES.txt'
writing manifest file 'ipgrep.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/i5avb0c6k17vy9qihi3bs7qwc9f757sf-ipgrep-1.0

xeji
xeji approved these changes Aug 1, 2018
View reviewed changes
Copy link
Contributor

@xeji xeji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Feedback was addressed.

@xeji xeji merged commit 2b75a72 into NixOS:master Aug 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil infinisil requested changes

@xeji xeji xeji approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@leenaars @xeji @GrahamcOfBorg @infinisil