Allow tests to be marked as SKIPPED. #1275
Merged
+17
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 22, 2018 02:20
tracking issue ziglang#1274; tests can be skipped by returnning `error.skip` :
tracking issue ziglang#1274 ;
…bstractions; depends on issue ziglang#1274 ;
tiehuis
reviewed
Jul 22, 2018
| }; | ||
|
|
||
| if (skip_test == true) { | ||
| return error.skip; |
There was a problem hiding this comment.
It may be better to use a name such as error.SkipZigTest (open to better suggestions) since this is global and we don't want a user to possibly use this name in their own code.
There was a problem hiding this comment.
@tiehuis Thanks!
I thought about that, but if used in user code, wouldn't it be caught before hand?
You bring up a good point and perhaps we could rename it to error.skip_test :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1274
tests can be skipped by returning
error.skip