Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

poppler_utils: 0.66.0 -> 0.67.0 #43915

Merged
merged 2 commits into from Jul 31, 2018
Merged

poppler_utils: 0.66.0 -> 0.67.0 #43915

merged 2 commits into from Jul 31, 2018

Conversation

r-ryantm
Copy link
Contributor

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/poppler-utils/versions.

meta.description for poppler_utils is: '"A PDF rendering library"'.

Checks done (click to expand)
  • built on NixOS
  • /nix/store/1c9081v3j0pl9xblzj1j5y2gcb8xaqzz-poppler-utils-0.67.0/bin/pdftoppm passed the binary check.
  • /nix/store/1c9081v3j0pl9xblzj1j5y2gcb8xaqzz-poppler-utils-0.67.0/bin/pdftocairo passed the binary check.
  • Warning: no invocation of /nix/store/1c9081v3j0pl9xblzj1j5y2gcb8xaqzz-poppler-utils-0.67.0/bin/pdfdetach had a zero exit code or showed the expected version
  • /nix/store/1c9081v3j0pl9xblzj1j5y2gcb8xaqzz-poppler-utils-0.67.0/bin/pdffonts passed the binary check.
  • /nix/store/1c9081v3j0pl9xblzj1j5y2gcb8xaqzz-poppler-utils-0.67.0/bin/pdfimages passed the binary check.
  • /nix/store/1c9081v3j0pl9xblzj1j5y2gcb8xaqzz-poppler-utils-0.67.0/bin/pdfinfo passed the binary check.
  • /nix/store/1c9081v3j0pl9xblzj1j5y2gcb8xaqzz-poppler-utils-0.67.0/bin/pdfsig passed the binary check.
  • /nix/store/1c9081v3j0pl9xblzj1j5y2gcb8xaqzz-poppler-utils-0.67.0/bin/pdftops passed the binary check.
  • /nix/store/1c9081v3j0pl9xblzj1j5y2gcb8xaqzz-poppler-utils-0.67.0/bin/pdftotext passed the binary check.
  • /nix/store/1c9081v3j0pl9xblzj1j5y2gcb8xaqzz-poppler-utils-0.67.0/bin/pdftohtml passed the binary check.
  • /nix/store/1c9081v3j0pl9xblzj1j5y2gcb8xaqzz-poppler-utils-0.67.0/bin/pdfseparate passed the binary check.
  • /nix/store/1c9081v3j0pl9xblzj1j5y2gcb8xaqzz-poppler-utils-0.67.0/bin/pdfunite passed the binary check.
  • 11 of 12 passed binary check by having a zero exit code.
  • 0 of 12 passed binary check by having the new version present in output.
  • found 0.67.0 with grep in /nix/store/1c9081v3j0pl9xblzj1j5y2gcb8xaqzz-poppler-utils-0.67.0
  • directory tree listing: https://gist.github.com/348464082ac89fae1adccb593e9bf178
  • du listing: https://gist.github.com/9df233895f964e5b31fa54887cfd5701
Test this build with Cachix (click to expand)

One time setup in nixpkgs Git checkout:

cachix use r-ryantm
git remote add r-ryantm https://github.com/r-ryantm/nixpkgs.git

Test this build:

git fetch r-ryantm && git checkout 7d016502d88a89bebb2fd8728a5bb40702a7feba && nix-shell --pure -I nixpkgs=. -p poppler_utils

cc @ttuegel for testing.

poppler_utils: 0.66.0 -> 0.67.0
7d01650 
Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/poppler-utils/versions.
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: poppler_utils

Partial log (click to expand)

strip is /nix/store/7iyn7gn33i7xxjgmwf25k20246y6nd9d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/xwlf6fr32sjbgdyv16gl8bmjsqh8xlf6-poppler-utils-0.67.0/lib  /nix/store/xwlf6fr32sjbgdyv16gl8bmjsqh8xlf6-poppler-utils-0.67.0/bin
patching script interpreter paths in /nix/store/xwlf6fr32sjbgdyv16gl8bmjsqh8xlf6-poppler-utils-0.67.0
checking for references to /build in /nix/store/xwlf6fr32sjbgdyv16gl8bmjsqh8xlf6-poppler-utils-0.67.0...
shrinking RPATHs of ELF executables and libraries in /nix/store/jh6c3wv4mpvycvffaw1cfb04izbyljfq-poppler-utils-0.67.0-dev
strip is /nix/store/7iyn7gn33i7xxjgmwf25k20246y6nd9d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/jh6c3wv4mpvycvffaw1cfb04izbyljfq-poppler-utils-0.67.0-dev/lib
patching script interpreter paths in /nix/store/jh6c3wv4mpvycvffaw1cfb04izbyljfq-poppler-utils-0.67.0-dev
checking for references to /build in /nix/store/jh6c3wv4mpvycvffaw1cfb04izbyljfq-poppler-utils-0.67.0-dev...
/nix/store/xwlf6fr32sjbgdyv16gl8bmjsqh8xlf6-poppler-utils-0.67.0

jtojnar
jtojnar requested changes Jul 21, 2018
View reviewed changes
Copy link
Contributor

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The darwin patch will need to be removed.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: poppler_utils

Partial log (click to expand)

strip is /nix/store/90vmpr41dzsx350k5argycaf693hnl1l-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/6rfmdp9gixf5ia52yda2hf1ip71b8d6i-poppler-utils-0.67.0/lib  /nix/store/6rfmdp9gixf5ia52yda2hf1ip71b8d6i-poppler-utils-0.67.0/bin
patching script interpreter paths in /nix/store/6rfmdp9gixf5ia52yda2hf1ip71b8d6i-poppler-utils-0.67.0
checking for references to /build in /nix/store/6rfmdp9gixf5ia52yda2hf1ip71b8d6i-poppler-utils-0.67.0...
shrinking RPATHs of ELF executables and libraries in /nix/store/ym23aldhaz7irzpmhblwp7pcbjnbkwdk-poppler-utils-0.67.0-dev
strip is /nix/store/90vmpr41dzsx350k5argycaf693hnl1l-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/ym23aldhaz7irzpmhblwp7pcbjnbkwdk-poppler-utils-0.67.0-dev/lib
patching script interpreter paths in /nix/store/ym23aldhaz7irzpmhblwp7pcbjnbkwdk-poppler-utils-0.67.0-dev
checking for references to /build in /nix/store/ym23aldhaz7irzpmhblwp7pcbjnbkwdk-poppler-utils-0.67.0-dev...
/nix/store/6rfmdp9gixf5ia52yda2hf1ip71b8d6i-poppler-utils-0.67.0

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: poppler_utils

Partial log (click to expand)

setting SOURCE_DATE_EPOCH to timestamp 1532035346 of file poppler-0.67.0/ChangeLog
patching sources
applying patch /nix/store/w3gv8xdylcglr9rkp3chcdm56hhq5vna-?id=267228bb071016621c80fc8514927905164aaeea
patching file utils/pdfsig.cc
Reversed (or previously applied) patch detected!  Assume -R? [n]
Apply anyway? [n]
Skipping patch.
2 out of 2 hunks ignored -- saving rejects to file utils/pdfsig.cc.rej
builder for '/nix/store/pw1hzzk14sq3w0qip5ssv6bs89z9jwx3-poppler-utils-0.67.0.drv' failed with exit code 1
�[31;1merror:�[0m build of '/nix/store/pw1hzzk14sq3w0qip5ssv6bs89z9jwx3-poppler-utils-0.67.0.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: poppler_utils

Partial log (click to expand)

gzipping man pages under /nix/store/83i49gj265z4f5d9rg6ndpafvkzny0g2-poppler-utils-0.67.0/share/man/
strip is /nix/store/1hi76hr87bd1y1q1qjk0lv8nmcjip1c8-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/83i49gj265z4f5d9rg6ndpafvkzny0g2-poppler-utils-0.67.0/lib  /nix/store/83i49gj265z4f5d9rg6ndpafvkzny0g2-poppler-utils-0.67.0/bin
patching script interpreter paths in /nix/store/83i49gj265z4f5d9rg6ndpafvkzny0g2-poppler-utils-0.67.0
checking for references to /build in /nix/store/83i49gj265z4f5d9rg6ndpafvkzny0g2-poppler-utils-0.67.0...
shrinking RPATHs of ELF executables and libraries in /nix/store/8hgdhbv5lvsy7836hzavkk6jzhiky5ds-poppler-utils-0.67.0-dev
strip is /nix/store/1hi76hr87bd1y1q1qjk0lv8nmcjip1c8-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/8hgdhbv5lvsy7836hzavkk6jzhiky5ds-poppler-utils-0.67.0-dev/lib
patching script interpreter paths in /nix/store/8hgdhbv5lvsy7836hzavkk6jzhiky5ds-poppler-utils-0.67.0-dev
checking for references to /build in /nix/store/8hgdhbv5lvsy7836hzavkk6jzhiky5ds-poppler-utils-0.67.0-dev...

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: poppler_utils

Partial log (click to expand)

strip is /nix/store/zrs21zqcchgyabjf4xfimncdq16njizc-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/9vzi167cq7mf0nyc145pk0b4qdz6kp1d-poppler-utils-0.67.0/lib  /nix/store/9vzi167cq7mf0nyc145pk0b4qdz6kp1d-poppler-utils-0.67.0/bin
patching script interpreter paths in /nix/store/9vzi167cq7mf0nyc145pk0b4qdz6kp1d-poppler-utils-0.67.0
checking for references to /build in /nix/store/9vzi167cq7mf0nyc145pk0b4qdz6kp1d-poppler-utils-0.67.0...
shrinking RPATHs of ELF executables and libraries in /nix/store/r18dbl124kvaf8l83hrmird5al2jpbga-poppler-utils-0.67.0-dev
strip is /nix/store/zrs21zqcchgyabjf4xfimncdq16njizc-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/r18dbl124kvaf8l83hrmird5al2jpbga-poppler-utils-0.67.0-dev/lib
patching script interpreter paths in /nix/store/r18dbl124kvaf8l83hrmird5al2jpbga-poppler-utils-0.67.0-dev
checking for references to /build in /nix/store/r18dbl124kvaf8l83hrmird5al2jpbga-poppler-utils-0.67.0-dev...
/nix/store/9vzi167cq7mf0nyc145pk0b4qdz6kp1d-poppler-utils-0.67.0

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: poppler_utils

Partial log (click to expand)

Patching '/nix/store/1v789lj75likngwa8hqfm4k3jlhiyifb-poppler-utils-0.67.0-dev/lib/pkgconfig/poppler-glib.pc' includedir to output /nix/store/1v789lj75likngwa8hqfm4k3jlhiyifb-poppler-utils-0.67.0-dev
Patching '/nix/store/1v789lj75likngwa8hqfm4k3jlhiyifb-poppler-utils-0.67.0-dev/lib/pkgconfig/poppler-splash.pc' includedir to output /nix/store/1v789lj75likngwa8hqfm4k3jlhiyifb-poppler-utils-0.67.0-dev
Patching '/nix/store/1v789lj75likngwa8hqfm4k3jlhiyifb-poppler-utils-0.67.0-dev/lib/pkgconfig/poppler.pc' includedir to output /nix/store/1v789lj75likngwa8hqfm4k3jlhiyifb-poppler-utils-0.67.0-dev
gzipping man pages under /nix/store/891pzf2vdvr9xg0c0l3zj3n2hhiwmd4w-poppler-utils-0.67.0/share/man/
strip is /nix/store/qfxcr8c4fg7lkybrny9n2sb77bmippdx-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/891pzf2vdvr9xg0c0l3zj3n2hhiwmd4w-poppler-utils-0.67.0/lib  /nix/store/891pzf2vdvr9xg0c0l3zj3n2hhiwmd4w-poppler-utils-0.67.0/bin
patching script interpreter paths in /nix/store/891pzf2vdvr9xg0c0l3zj3n2hhiwmd4w-poppler-utils-0.67.0
strip is /nix/store/qfxcr8c4fg7lkybrny9n2sb77bmippdx-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/1v789lj75likngwa8hqfm4k3jlhiyifb-poppler-utils-0.67.0-dev/lib
patching script interpreter paths in /nix/store/1v789lj75likngwa8hqfm4k3jlhiyifb-poppler-utils-0.67.0-dev

xeji
xeji approved these changes Jul 30, 2018
View reviewed changes
Copy link
Contributor

@xeji xeji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Darwin patch removed. LGTM.

@xeji
Copy link
Contributor

xeji commented Jul 31, 2018

@jtojnar ok to merge?

@jtojnar
Copy link
Contributor

jtojnar commented Jul 31, 2018

LGTM according to changelog.

@xeji
Copy link
Contributor

xeji commented Jul 31, 2018

I built a few reverse dependencies, looked ok.

@xeji xeji merged commit d68430d into NixOS:master Jul 31, 2018
@calvertvl calvertvl mentioned this pull request Jul 31, 2018
Closed
@r-ryantm r-ryantm deleted the auto-update/poppler-utils branch August 2, 2018 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar requested changes

@xeji xeji xeji approved these changes

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@r-ryantm @GrahamcOfBorg @xeji @jtojnar