Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: 7c8af7e9f981
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: 7db4c3617ff4
Choose a head ref
  • 3 commits
  • 3 files changed
  • 2 contributors

Commits on Jul 19, 2018

  1. xgboost: 0.7 -> 0.72

    @Ma27
    Ma27 committed Jul 19, 2018
    Configuration menu
    Copy the full SHA
    b9e7469 View commit details
    Browse the repository at this point in the history

  2. pythonPackages.xgboost: fix build 

    The setup.py of `python-package` contains some path resolution magic to
find `libxgboost.so` which is needed for the python API.

Unfortunately the code is incompatible with Nix as it isn't compatible
with the store-based structure for each package and tries to express the
location of the shared object with relative paths.

The detection in `setup.py` and `xgboost/libpath.py` has been either
removed entirely or patched to link to the proper store path of the
`libxgboost` build input.

See https://hydra.nixos.org/build/77702715 for further reference.
    @Ma27
    Ma27 committed Jul 19, 2018
    Configuration menu
    Copy the full SHA
    88a35d8 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2018

  1. Merge pull request #43809 from Ma27/fix-python-xgboost 

    pythonPackages.xgboost: fix build
    @FRidh
    FRidh committed Jul 21, 2018
    Configuration menu
    Copy the full SHA
    7db4c36 View commit details
    Browse the repository at this point in the history