Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yaxg: init at 2018-07-20 #43866

Merged
merged 3 commits into from Jul 25, 2018
Merged

yaxg: init at 2018-07-20 #43866

merged 3 commits into from Jul 25, 2018

Conversation

neonfuz
Copy link
Contributor

@neonfuz neonfuz commented Jul 20, 2018

Motivation for this change

This adds yaxg, a screenshot / screen recording tool similar to scrot. This wraps maim, slop, ffmpeg, and byzanz for all of it's functionality, all of which are already in nixos, so this is a pretty simple inclusion.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@neonfuz
Copy link
Contributor Author

neonfuz commented Jul 24, 2018

Made some fixes:

  • Replaced makeWrapper with wrapProgram. This is the more proper nixos way, I just didn't know about it originally.
  • Set version date to the date of the last change rather than the date I decided to pull.
  • Minor formatting changes

@ryantm
Copy link
Member

ryantm commented Jul 25, 2018

@GrahamcOfBorg build yaxg

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: yaxg

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: yaxg

Partial log (click to expand)

no Makefile, doing nothing
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/dp4vslijlf7vlisbzijg4rjgrhw7ziv2-yaxg-unstable-2018-05-03
strip is /nix/store/a3nk8z2i7m7wa3jdckgv710n7j3yx4b5-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/dp4vslijlf7vlisbzijg4rjgrhw7ziv2-yaxg-unstable-2018-05-03/bin
patching script interpreter paths in /nix/store/dp4vslijlf7vlisbzijg4rjgrhw7ziv2-yaxg-unstable-2018-05-03
/nix/store/dp4vslijlf7vlisbzijg4rjgrhw7ziv2-yaxg-unstable-2018-05-03/bin/.yaxg-wrapped: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/fcyxw5aslw3a82p33x5lhckj0mr6g1s4-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/dp4vslijlf7vlisbzijg4rjgrhw7ziv2-yaxg-unstable-2018-05-03...
/nix/store/dp4vslijlf7vlisbzijg4rjgrhw7ziv2-yaxg-unstable-2018-05-03

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: yaxg

Partial log (click to expand)

no Makefile, doing nothing
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/l372vlv7dldnfngswdr3pisc4lv37w4m-yaxg-unstable-2018-05-03
strip is /nix/store/a245zacjzf3qw0davhvlfarihcy2yyrc-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/l372vlv7dldnfngswdr3pisc4lv37w4m-yaxg-unstable-2018-05-03/bin
patching script interpreter paths in /nix/store/l372vlv7dldnfngswdr3pisc4lv37w4m-yaxg-unstable-2018-05-03
/nix/store/l372vlv7dldnfngswdr3pisc4lv37w4m-yaxg-unstable-2018-05-03/bin/.yaxg-wrapped: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/n86k15k75jfjqx7k4lzprj055pm7ssjn-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/l372vlv7dldnfngswdr3pisc4lv37w4m-yaxg-unstable-2018-05-03...
/nix/store/l372vlv7dldnfngswdr3pisc4lv37w4m-yaxg-unstable-2018-05-03

@ryantm ryantm merged commit 49ae194 into NixOS:master Jul 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantm ryantm ryantm approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@neonfuz @ryantm @GrahamcOfBorg @Janik-Haag