Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gopass: 1.8.1 -> 1.8.2 #43885

Merged
merged 1 commit into from Jul 21, 2018
Merged

gopass: 1.8.1 -> 1.8.2 #43885

merged 1 commit into from Jul 21, 2018

Conversation

mkaito
Copy link
Contributor

@mkaito mkaito commented Jul 21, 2018

Motivation for this change

Update gopass

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@FRidh
Copy link
Member

FRidh commented Jul 21, 2018

@GrahamcOfBorg build gopass

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: gopass

Partial log (click to expand)

github.com/gopasspw/gopass
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/dyvmk4wbj5sxcchkg4wykadnldbgx9h1-gopass-1.8.2-bin
shrinking /nix/store/dyvmk4wbj5sxcchkg4wykadnldbgx9h1-gopass-1.8.2-bin/bin/gopass
strip is /nix/store/7iyn7gn33i7xxjgmwf25k20246y6nd9d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/dyvmk4wbj5sxcchkg4wykadnldbgx9h1-gopass-1.8.2-bin/bin
patching script interpreter paths in /nix/store/dyvmk4wbj5sxcchkg4wykadnldbgx9h1-gopass-1.8.2-bin
checking for references to /build in /nix/store/dyvmk4wbj5sxcchkg4wykadnldbgx9h1-gopass-1.8.2-bin...
strip is /nix/store/7iyn7gn33i7xxjgmwf25k20246y6nd9d-binutils-2.30/bin/strip

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: gopass

Partial log (click to expand)

find: '/nix/store/my9n61sa6dkyn7ws153rqhy6jd81ixp6-gopass-1.8.2': No such file or directory
find: '/nix/store/my9n61sa6dkyn7ws153rqhy6jd81ixp6-gopass-1.8.2': No such file or directory
find: '/nix/store/my9n61sa6dkyn7ws153rqhy6jd81ixp6-gopass-1.8.2': No such file or directory
find: '/nix/store/my9n61sa6dkyn7ws153rqhy6jd81ixp6-gopass-1.8.2': No such file or directory
find: '/nix/store/my9n61sa6dkyn7ws153rqhy6jd81ixp6-gopass-1.8.2': No such file or directory
find: '/nix/store/my9n61sa6dkyn7ws153rqhy6jd81ixp6-gopass-1.8.2': No such file or directory
find: '/nix/store/my9n61sa6dkyn7ws153rqhy6jd81ixp6-gopass-1.8.2': No such file or directory
find: '/nix/store/my9n61sa6dkyn7ws153rqhy6jd81ixp6-gopass-1.8.2': No such file or directory
find: '/nix/store/my9n61sa6dkyn7ws153rqhy6jd81ixp6-gopass-1.8.2': No such file or directory
/nix/store/rlj3baacigj3pyn0pkiwjn9k92x229qd-gopass-1.8.2-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gopass

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/1bdfpamzk8ynwfilz8bmk7a8z9gcd4c3-gopass-1.8.2-bin
shrinking /nix/store/1bdfpamzk8ynwfilz8bmk7a8z9gcd4c3-gopass-1.8.2-bin/bin/gopass
strip is /nix/store/90vmpr41dzsx350k5argycaf693hnl1l-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/1bdfpamzk8ynwfilz8bmk7a8z9gcd4c3-gopass-1.8.2-bin/bin
patching script interpreter paths in /nix/store/1bdfpamzk8ynwfilz8bmk7a8z9gcd4c3-gopass-1.8.2-bin
checking for references to /build in /nix/store/1bdfpamzk8ynwfilz8bmk7a8z9gcd4c3-gopass-1.8.2-bin...
strip is /nix/store/90vmpr41dzsx350k5argycaf693hnl1l-binutils-2.30/bin/strip
/nix/store/1bdfpamzk8ynwfilz8bmk7a8z9gcd4c3-gopass-1.8.2-bin

flokli
flokli requested changes Jul 21, 2018
View reviewed changes
Copy link
Contributor

@flokli flokli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gopasspw/gopass#880 and gopasspw/gopass#882 merged, we should be able to strip lines 29-31.

@Mic92 Mic92 merged commit c8632c2 into NixOS:master Jul 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flokli flokli flokli requested changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mkaito @FRidh @GrahamcOfBorg @flokli @Mic92