Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

browsh: init at 1.4.10 #44251

Merged
merged 2 commits into from Jul 31, 2018
Merged

browsh: init at 1.4.10 #44251

merged 2 commits into from Jul 31, 2018

Conversation

kalbasit
Copy link
Member

@kalbasit kalbasit commented Jul 31, 2018 •
edited

Motivation for this change

A fully-modern text-based browser, rendering to TTY and browsers. https://www.brow.sh/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

closes #43283

@kalbasit kalbasit mentioned this pull request Jul 31, 2018
Closed
@dtzWill
Copy link
Member

dtzWill commented Jul 31, 2018

Seems to work here! :D

@teto
Copy link
Member

teto commented Jul 31, 2018

works here too.

Mic92
Mic92 reviewed Jul 31, 2018
View reviewed changes
pkgs/applications/networking/browsers/browsh/default.nix Outdated
@@ -0,0 +1,60 @@
{ stdenv, buildGoPackage, fetchurl, fetchFromGitHub, go-bindata, ... }:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... is not required.

@Mic92
Copy link
Member

Mic92 commented Jul 31, 2018

@GrahamcOfBorg build browsh

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: browsh

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/5rl4azqragmq50wmx1d09xy75m5ybi0h-browsh-1.4.10-bin
shrinking /nix/store/5rl4azqragmq50wmx1d09xy75m5ybi0h-browsh-1.4.10-bin/bin/browsh
strip is /nix/store/zrs21zqcchgyabjf4xfimncdq16njizc-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/5rl4azqragmq50wmx1d09xy75m5ybi0h-browsh-1.4.10-bin/bin
patching script interpreter paths in /nix/store/5rl4azqragmq50wmx1d09xy75m5ybi0h-browsh-1.4.10-bin
checking for references to /build in /nix/store/5rl4azqragmq50wmx1d09xy75m5ybi0h-browsh-1.4.10-bin...
strip is /nix/store/zrs21zqcchgyabjf4xfimncdq16njizc-binutils-2.30/bin/strip
/nix/store/5rl4azqragmq50wmx1d09xy75m5ybi0h-browsh-1.4.10-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: browsh

Partial log (click to expand)

browsh/interfacer/src
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/pbfi0wfcyxxsnbwgbqh293y73sbkbygh-browsh-1.4.10-bin
shrinking /nix/store/pbfi0wfcyxxsnbwgbqh293y73sbkbygh-browsh-1.4.10-bin/bin/browsh
strip is /nix/store/1hi76hr87bd1y1q1qjk0lv8nmcjip1c8-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/pbfi0wfcyxxsnbwgbqh293y73sbkbygh-browsh-1.4.10-bin/bin
patching script interpreter paths in /nix/store/pbfi0wfcyxxsnbwgbqh293y73sbkbygh-browsh-1.4.10-bin
checking for references to /build in /nix/store/pbfi0wfcyxxsnbwgbqh293y73sbkbygh-browsh-1.4.10-bin...
strip is /nix/store/1hi76hr87bd1y1q1qjk0lv8nmcjip1c8-binutils-2.30/bin/strip

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: browsh

Partial log (click to expand)

find: '/nix/store/v5ym7pdrqgbcmip2ax9n3bq1f346nzz8-browsh-1.4.10': No such file or directory
find: '/nix/store/v5ym7pdrqgbcmip2ax9n3bq1f346nzz8-browsh-1.4.10': No such file or directory
find: '/nix/store/v5ym7pdrqgbcmip2ax9n3bq1f346nzz8-browsh-1.4.10': No such file or directory
find: '/nix/store/v5ym7pdrqgbcmip2ax9n3bq1f346nzz8-browsh-1.4.10': No such file or directory
find: '/nix/store/v5ym7pdrqgbcmip2ax9n3bq1f346nzz8-browsh-1.4.10': No such file or directory
find: '/nix/store/v5ym7pdrqgbcmip2ax9n3bq1f346nzz8-browsh-1.4.10': No such file or directory
find: '/nix/store/v5ym7pdrqgbcmip2ax9n3bq1f346nzz8-browsh-1.4.10': No such file or directory
find: '/nix/store/v5ym7pdrqgbcmip2ax9n3bq1f346nzz8-browsh-1.4.10': No such file or directory
find: '/nix/store/v5ym7pdrqgbcmip2ax9n3bq1f346nzz8-browsh-1.4.10': No such file or directory
/nix/store/78k3l03wf3zmf5zjn36ik6f5qm4gsyl6-browsh-1.4.10-bin

@Mic92 Mic92 merged commit 94cbb8e into NixOS:master Jul 31, 2018
@kalbasit kalbasit deleted the add-browsh branch July 31, 2018 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[package request] browsh
5 participants
@kalbasit @dtzWill @teto @Mic92 @GrahamcOfBorg