Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

makemkv: 1.12.2 -> 1.12.3 #44252

Merged
merged 1 commit into from Jul 31, 2018
Merged

makemkv: 1.12.2 -> 1.12.3 #44252

merged 1 commit into from Jul 31, 2018

Conversation

danieldk
Copy link
Contributor

Changelog: http://www.makemkv.com/download/history.html

Motivation for this change

1.12.2 download URL expired, new release provides many small improvements.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Jul 31, 2018

unfree package, build checked locally.

@xeji xeji merged commit 8b33abd into NixOS:master Jul 31, 2018
@danieldk danieldk deleted the makemkv-1.12.3 branch September 5, 2018 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danieldk @xeji @GrahamcOfBorg