kail: init at 0.6.0 #43278
Merged
kail: init at 0.6.0 #43278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
offlinehacker
force-pushed
the
pkgs/kail/init
branch
2 times, most recently
from
a8628aa
to
97bb53f
Compare
|
Success on aarch64-linux (full log) Attempted: kail Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: kail Partial log (click to expand)
|
nlewo
requested changes
Jul 10, 2018
| goDeps = ./deps.nix; | ||
|
|
||
| meta = with stdenv.lib; { | ||
| description = "kubernetes log viewer"; |
There was a problem hiding this comment.
Could you capitalize the first letter of the desc?
|
|
||
| # regenerate deps.nix using following steps: | ||
| # | ||
| # go get -u github.com/boz/kail |
There was a problem hiding this comment.
I think it would be better to checkout the release before generating dependencies. It seems we are building the v0.6.0 with the deps of master.
There was a problem hiding this comment.
I added comment to checkout actual version
| @@ -0,0 +1,30 @@ | |||
| { stdenv, buildGoPackage, fetchFromGitHub, fetchgit, fetchhg, fetchbzr, fetchsvn }: | |||
There was a problem hiding this comment.
Would be nice to remove useless arguments.
| src = fetchFromGitHub { | ||
| owner = "boz"; | ||
| repo = "kail"; | ||
| rev = "v0.6.0"; |
nlewo
reviewed
Jul 10, 2018
|
|
||
| meta = with stdenv.lib; { | ||
| description = "kubernetes log viewer"; | ||
| homepage = "https://github.com/boz/kail"; |
There was a problem hiding this comment.
Even though I was the one to open that PR, there was a significant amount of people not liking it: #27809 (comment)
There was a problem hiding this comment.
I don't like too this! I just read your comment and I could also add it's hard for new comers to know this syntax. But I always tries to refer to the manual which doesn't use quote for urls:/
offlinehacker
force-pushed
the
pkgs/kail/init
branch
from
97bb53f
to
90c05e9
Compare
|
Fixed all the changes requested above |
|
Success on aarch64-linux (full log) Attempted: kail Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: kail Partial log (click to expand)
|
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kail is kubernetes log viewer