Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pstoedit: patch to ensure gs-9.22 compatibilty #43280

Merged
merged 1 commit into from Jul 10, 2018
Merged

pstoedit: patch to ensure gs-9.22 compatibilty #43280

merged 1 commit into from Jul 10, 2018

Conversation

markuskowa
Copy link
Member

@markuskowa markuskowa commented Jul 10, 2018 •
edited

Motivation for this change

pstoedit calls ghostscript with the DELAYBIND option. This option is not support anymore
in gs-9.22. It is now called REALLYDELAYBIND. Newer versions of pstoedit add a compatibility switch
(-rdb) to activate the new option. However, programs like inkscape, which call pstoedit in the background do not know about this requirement and will fail eventually (i.e. gs refuses to the take old DELAYBIND option).

With this patch typesetting LaTex formulas in inkscape works again.

Things done

Introduce patch to turn on -rdb command line option by default.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

cc @MarcWeber

@xeji
Copy link
Contributor

xeji commented Jul 10, 2018

@GrahamcOfBorg build pstoedit

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: pstoedit

Partial log (click to expand)

gzipping man pages under /nix/store/vdi0rb0bcf1arwp671kasfy3vx79r3px-pstoedit-3.73/share/man/
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/vdi0rb0bcf1arwp671kasfy3vx79r3px-pstoedit-3.73/lib  /nix/store/vdi0rb0bcf1arwp671kasfy3vx79r3px-pstoedit-3.73/bin 
patching script interpreter paths in /nix/store/vdi0rb0bcf1arwp671kasfy3vx79r3px-pstoedit-3.73
checking for references to /tmp/nix-build-pstoedit-3.73.drv-0 in /nix/store/vdi0rb0bcf1arwp671kasfy3vx79r3px-pstoedit-3.73...
shrinking RPATHs of ELF executables and libraries in /nix/store/m6vf4bs02wa0dyl2a840pyqpsjnsm9xm-pstoedit-3.73-dev
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/m6vf4bs02wa0dyl2a840pyqpsjnsm9xm-pstoedit-3.73-dev/lib 
patching script interpreter paths in /nix/store/m6vf4bs02wa0dyl2a840pyqpsjnsm9xm-pstoedit-3.73-dev
checking for references to /tmp/nix-build-pstoedit-3.73.drv-0 in /nix/store/m6vf4bs02wa0dyl2a840pyqpsjnsm9xm-pstoedit-3.73-dev...

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: pstoedit

Partial log (click to expand)

/nix/store/rj9zcjl3wih24ia2yvar76nwwn364hxg-pstoedit-3.73/lib/libpstoedit.0.dylib: fixing dylib
/nix/store/rj9zcjl3wih24ia2yvar76nwwn364hxg-pstoedit-3.73/lib/libpstoedit.0.dylib: fixing dylib
/nix/store/rj9zcjl3wih24ia2yvar76nwwn364hxg-pstoedit-3.73/lib/libpstoedit.0.dylib: fixing dylib
/nix/store/rj9zcjl3wih24ia2yvar76nwwn364hxg-pstoedit-3.73/lib/libpstoedit.0.dylib: fixing dylib
/nix/store/rj9zcjl3wih24ia2yvar76nwwn364hxg-pstoedit-3.73/lib/libpstoedit.0.dylib: fixing dylib
/nix/store/rj9zcjl3wih24ia2yvar76nwwn364hxg-pstoedit-3.73/lib/libpstoedit.0.dylib: fixing dylib
strip is /nix/store/7ddbq63v97nk8gkbf7gcsfmby37h6gbl-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/2smz2agdiksqxzc3lm8z69dyyr3ycx6k-pstoedit-3.73-dev/lib
patching script interpreter paths in /nix/store/2smz2agdiksqxzc3lm8z69dyyr3ycx6k-pstoedit-3.73-dev
/nix/store/rj9zcjl3wih24ia2yvar76nwwn364hxg-pstoedit-3.73

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: pstoedit

Partial log (click to expand)

strip is /nix/store/0pjsgkxz0rp5baycq5sp2s72lrr5q9sg-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/laff6h9nb2mdh74qai6i1cb4fl9b7llf-pstoedit-3.73/lib  /nix/store/laff6h9nb2mdh74qai6i1cb4fl9b7llf-pstoedit-3.73/bin
patching script interpreter paths in /nix/store/laff6h9nb2mdh74qai6i1cb4fl9b7llf-pstoedit-3.73
checking for references to /build in /nix/store/laff6h9nb2mdh74qai6i1cb4fl9b7llf-pstoedit-3.73...
shrinking RPATHs of ELF executables and libraries in /nix/store/xmsrxf5bql4cizbf8vca9880ma9zahwr-pstoedit-3.73-dev
strip is /nix/store/0pjsgkxz0rp5baycq5sp2s72lrr5q9sg-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/xmsrxf5bql4cizbf8vca9880ma9zahwr-pstoedit-3.73-dev/lib
patching script interpreter paths in /nix/store/xmsrxf5bql4cizbf8vca9880ma9zahwr-pstoedit-3.73-dev
checking for references to /build in /nix/store/xmsrxf5bql4cizbf8vca9880ma9zahwr-pstoedit-3.73-dev...
/nix/store/laff6h9nb2mdh74qai6i1cb4fl9b7llf-pstoedit-3.73

@xeji xeji merged commit bceb0ee into NixOS:master Jul 10, 2018
@markuskowa markuskowa deleted the pstoedit-pr branch July 11, 2018 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@markuskowa @xeji @GrahamcOfBorg