Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add libudev, which Ledger Live app requires #43269

Merged
merged 1 commit into from Jul 11, 2018
Merged

Add libudev, which Ledger Live app requires #43269

merged 1 commit into from Jul 11, 2018

Conversation

reardencode
Copy link
Contributor

Motivation for this change

Ledger Live app didn't work

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@joachifm
Copy link
Contributor

cc @tilpner

tilpner
tilpner approved these changes Jul 11, 2018
View reviewed changes
Copy link
Member

@tilpner tilpner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The list was expected to grow as required by applications, and libudev doesn't seem exotic.

@joachifm joachifm merged commit 5f59d13 into NixOS:master Jul 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tilpner tilpner tilpner approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@reardencode @joachifm @tilpner @GrahamcOfBorg @Janik-Haag