Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

liblxqt: 0.12.0 -> 0.13.0 #43273

Closed
wants to merge 1 commit into from
Closed

liblxqt: 0.12.0 -> 0.13.0 #43273

wants to merge 1 commit into from

Conversation

colonelpanic8
Copy link
Contributor

Fixes #43272

Motivation for this change

Fixes compilation and its an update

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Possibly need a bit of testing since several things depend on it.

@xeji
Copy link
Contributor

xeji commented Jul 12, 2018

This is part of the larger lxqt update in #40982 or #40899. I think it would be better to do move to lxqt 0.13 in one step. Bumping only liblxqt may interfere with the other lxqt packages.
cc @romildo

@colonelpanic8
Copy link
Contributor Author

@xeji makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@colonelpanic8 @xeji @GrahamcOfBorg