Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in nixos/tests/taskserver.nix #43284

Merged
merged 1 commit into from Jul 11, 2018
Merged

Typo in nixos/tests/taskserver.nix #43284

merged 1 commit into from Jul 11, 2018

Conversation

OliverEvans96
Copy link
Contributor

snakoil -> snakeoil

@vcunat
Copy link
Member

vcunat commented Jul 10, 2018

Hmm, I wonder if "Templace" should have been "Template", too.

@OliverEvans96
Copy link
Contributor Author

OliverEvans96 commented Jul 10, 2018 •
edited

Good catch, @GrahamcOfBorg ! edit: I mean @vcunat 😆

@xeji
Copy link
Contributor

xeji commented Jul 10, 2018

@GrahamcOfBorg test taskserver

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: tests.taskserver

Partial log (click to expand)

while evaluating anonymous function at /var/lib/gc-of-borg/nix-test-rs-12/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-12/lib/lists.nix:104:41, called from /var/lib/gc-of-borg/nix-test-rs-12/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-12/lib/modules.nix:324:17:
while evaluating anonymous function at /var/lib/gc-of-borg/nix-test-rs-12/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-12/lib/modules.nix:324:28, called from undefined position:
while evaluating 'dischargeProperties' at /var/lib/gc-of-borg/nix-test-rs-12/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-12/lib/modules.nix:392:25, called from /var/lib/gc-of-borg/nix-test-rs-12/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-12/lib/modules.nix:325:62:
while evaluating the attribute 'value' at /var/lib/gc-of-borg/nix-test-rs-12/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-12/lib/modules.nix:216:48:
while evaluating the attribute 'config.subnetMask' at /var/lib/gc-of-borg/nix-test-rs-12/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-12/lib/attrsets.nix:200:46:
while evaluating anonymous function at /var/lib/gc-of-borg/nix-test-rs-12/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-12/lib/modules.nix:75:45, called from /var/lib/gc-of-borg/nix-test-rs-12/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-12/lib/attrsets.nix:200:54:
while evaluating the attribute 'value' at /var/lib/gc-of-borg/nix-test-rs-12/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-12/lib/modules.nix:312:9:
while evaluating the option `networking.interfaces.eth1.subnetMask':
The option `networking.interfaces.eth1.subnetMask' is used but not defined.

@GrahamcOfBorg
Copy link

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: tests.taskserver

Partial log (click to expand)

while evaluating anonymous function at /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/builder-0-gustav.ewr1.nix.ci/lib/lists.nix:104:41, called from /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/builder-0-gustav.ewr1.nix.ci/lib/modules.nix:324:17:
while evaluating anonymous function at /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/builder-0-gustav.ewr1.nix.ci/lib/modules.nix:324:28, called from undefined position:
while evaluating 'dischargeProperties' at /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/builder-0-gustav.ewr1.nix.ci/lib/modules.nix:392:25, called from /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/builder-0-gustav.ewr1.nix.ci/lib/modules.nix:325:62:
while evaluating the attribute 'value' at /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/builder-0-gustav.ewr1.nix.ci/lib/modules.nix:216:48:
while evaluating the attribute 'config.subnetMask' at /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/builder-0-gustav.ewr1.nix.ci/lib/attrsets.nix:200:46:
while evaluating anonymous function at /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/builder-0-gustav.ewr1.nix.ci/lib/modules.nix:75:45, called from /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/builder-0-gustav.ewr1.nix.ci/lib/attrsets.nix:200:54:
while evaluating the attribute 'value' at /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/builder-0-gustav.ewr1.nix.ci/lib/modules.nix:312:9:
while evaluating the option `networking.interfaces.eth1.subnetMask':
The option `networking.interfaces.eth1.subnetMask' is used but not defined.

@vcunat
Copy link
Member

vcunat commented Jul 10, 2018 •
edited

Well, one has to fix both occurrences of the identifier – that's why I wondered about the typo, but perhaps with some clever auto-complete it's possible to make the same typo twice...

@xeji
Copy link
Contributor

xeji commented Jul 10, 2018

The eval error seems unrelated to this PR. Actually, I cannot find evidence of this test ever being run as far as hydra logs go. Will investigate.

@infinisil
Copy link
Member

Needs to get fixed here as well:

nixpkgs/nixos/tests/taskserver.nix

Lines 51 to 53 in 0b0696f

certtool -c --template "$userCertTemplace" \
--load-privkey "$out/alice.key" \

@infinisil
Copy link
Member

Now just squash the commits into one

@xeji
Copy link
Contributor

xeji commented Jul 10, 2018

FYI: Fixed eval error of this test in 7ac794f. The fix is independent of this PR.

@OliverEvans96
Copy link
Contributor Author

Rebased and squashed.

@xeji
Copy link
Contributor

xeji commented Jul 11, 2018

Thank you!

@xeji xeji merged commit 01bc14d into NixOS:master Jul 11, 2018
@xeji
Copy link
Contributor

xeji commented Jul 11, 2018

@OliverEvans96 in the future, please format your commit messages as described in CONTRIBUTING.MD . It's a convention to make our git logs easier to read and search. Thank you.

@OliverEvans96
Copy link
Contributor Author

Will do, thank you!

@OliverEvans96 OliverEvans96 deleted the OliverEvans96-patch-1 branch July 11, 2018 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@OliverEvans96 @vcunat @xeji @GrahamcOfBorg @infinisil @Janik-Haag