Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ufoai: 2.4 -> 2.5 #43270

Closed
wants to merge 1 commit into from
Closed

ufoai: 2.4 -> 2.5 #43270

wants to merge 1 commit into from

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jul 10, 2018

Add few more deps, set c++ standard to fix build.

2.5.0 was apparently released 2014-06-28,
so seems about time to update :).

https://ufoai.org/wiki/Changelog/2.5

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.


Only tested launching, not familiar with game so someone else should
probably vet this a bit more thoroughly.

cc maintainer @viric

Add few more deps, set c++ standard to fix build.
@dtzWill
Copy link
Member Author

dtzWill commented Jul 10, 2018

Hmm looking around this looks a bit messier to package "properly" and instead of doing it badly for sake of shiny newest, let's preserve what we already have :).

@dtzWill dtzWill closed this Jul 10, 2018
@dtzWill
Copy link
Member Author

dtzWill commented Jul 10, 2018

In case useful to anyone (perhaps myself) in the future, tagged some "WIP" commits building on this: https://github.com/dtzWill/nixpkgs/releases/tag/update%2Fufoai-2.5-wip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants