Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor cabal2nix lib api #357

Merged
merged 3 commits into from Jul 10, 2018
Merged

Refactor cabal2nix lib api #357

merged 3 commits into from Jul 10, 2018

Conversation

domenkozar
Copy link
Member

@domenkozar domenkozar commented Jul 10, 2018 •
edited

  1. Changes previous:
cabal2nix' :: [String] -> IO (Either Doc Derivation)
cabal2nixWithDB :: DB.HackageDB -> [String] -> IO (Either Doc Derivation)

into more typed

cabal2nix' :: Options -> IO (Either Doc Derivation)
cabal2nixWithDB :: DB.HackageDB -> Options -> IO (Either Doc Derivation)
parseArgs :: [String] -> IO Options

  1. Allows setting nixpkgs identifier with Options

  2. Exposes a function to ease use of Distribution.Nixpkgs.Haskell.Hackage module

These changes are required to make next release of https://github.com/input-output-hk/stack2nix

@domenkozar domenkozar requested a review from peti July 10, 2018 17:30
@domenkozar domenkozar mentioned this pull request Jul 10, 2018
Closed
2 tasks
@domenkozar
Copy link
Member Author

I know this is a breaking change, but it's trivial to migrate and I'd hate for another set of functions to land in.

@peti peti merged commit ae983e3 into master Jul 10, 2018
@peti peti deleted the refactor-cabal2nix branch July 10, 2018 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti Awaiting requested review from peti

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@domenkozar @peti