Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maintainer-list: sort and format #43311

Merged
merged 1 commit into from Jul 11, 2018
Merged

Conversation

infinisil
Copy link
Member

@infinisil infinisil commented Jul 11, 2018

Motivation for this change

Was inconveniently sorted since #36119. Namely since then all uppercase letters were before lowercase ones, so it's sorted like A-Za-z.

This restored the proper sorting and also corrects all formatting errors.

I used a mix of Nix, jq and vim to do the transformation, nothing was done by hand. I also checked via jq that all handles are still there (can also be seen on the commit, lines added = lines removed).

I'd like to get this merged asap so I don't have to deal with merge conflicts. I noticed this because lots of people in PRs are adding their handle to the A-Z list.

Ping @Profpatsch

Edit: This was how I did it (in case I need to repeat it after a conflict:

  • nix-instantiate --eval --strict --json -E 'let list = import ./maintainer-list.nix; lib = import <nixpkgs/lib>; in lib.sort (l: r: lib.toLower l.key < lib.toLower r.key) (map (n: { key = n; value = list.${n}; }) (builtins.attrNames list))' | jq from_entries > new.nix
  • In Vim:
    • :%s/"\(.*\)":/\1 =
    • :%s/$/;
    • :%s/,;/;
    • :%s/{;/{
    • Delete last ; and copy the description at the top from the original maintainer-list.nix

Was inconveniently sorted since NixOS#36119
@infinisil
Copy link
Member Author

The diff also highlights the people with an alternate alphabet very nicely 😁

@Profpatsch
Copy link
Member

Thanks!

@infinisil infinisil deleted the clean-maintainers branch July 11, 2018 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants