maintainer-list: sort and format #43311
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Was inconveniently sorted since #36119. Namely since then all uppercase letters were before lowercase ones, so it's sorted like A-Za-z.
This restored the proper sorting and also corrects all formatting errors.
I used a mix of Nix, jq and vim to do the transformation, nothing was done by hand. I also checked via jq that all handles are still there (can also be seen on the commit, lines added = lines removed).
I'd like to get this merged asap so I don't have to deal with merge conflicts. I noticed this because lots of people in PRs are adding their handle to the A-Z list.
Ping @Profpatsch
Edit: This was how I did it (in case I need to repeat it after a conflict:
nix-instantiate --eval --strict --json -E 'let list = import ./maintainer-list.nix; lib = import <nixpkgs/lib>; in lib.sort (l: r: lib.toLower l.key < lib.toLower r.key) (map (n: { key = n; value = list.${n}; }) (builtins.attrNames list))' | jq from_entries > new.nix
:%s/"\(.*\)":/\1 =
:%s/$/;
:%s/,;/;
:%s/{;/{
;
and copy the description at the top from the originalmaintainer-list.nix