Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

radare2: 2.6.0 -> 2.7.0; radare2-cutter: 1.4 -> 1.5 #43309

Merged
merged 5 commits into from Jul 11, 2018
Merged

radare2: 2.6.0 -> 2.7.0; radare2-cutter: 1.4 -> 1.5 #43309

merged 5 commits into from Jul 11, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jul 10, 2018

Update together--not strictly needed but least we can do since we don't
use radare2-cutter's radare2 submodule.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@dtzWill dtzWill requested a review from Mic92 July 10, 2018 23:57
@dtzWill
Copy link
Member Author

dtzWill commented Jul 10, 2018

Thanks radare2-review buddy ^_^.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: cutter, radare2, radare2-cutter

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: cutter, radare2, radare2-cutter

Partial log (click to expand)

strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/kvacj3qcxmz90ayxa0r0mpch2qldpar3-radare2-cutter-1.5/bin
patching script interpreter paths in /nix/store/kvacj3qcxmz90ayxa0r0mpch2qldpar3-radare2-cutter-1.5
checking for references to /build in /nix/store/kvacj3qcxmz90ayxa0r0mpch2qldpar3-radare2-cutter-1.5...
postPatchMkspecs
postPatchMkspecs
postPatchMkspecs
/nix/store/i6gncjr1ylz29l0xh5n0n4ix3wnhag9i-cutter-1.04
/nix/store/4swf09azdvgzm0pykwn9j2yyh3vic0rh-radare2-2.7.0
/nix/store/kvacj3qcxmz90ayxa0r0mpch2qldpar3-radare2-cutter-1.5

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: cutter, radare2, radare2-cutter

Partial log (click to expand)

[6778/16620] CXX obj/third_party/webrtc/modules/rtp_rtcp/rtp_rtcp_format/transport_feedback.o
[6779/16620] CXX obj/third_party/webrtc/modules/video_capture/video_capture/device_info_external.o
[6780/16620] CXX obj/third_party/webrtc/modules/rtp_rtcp/rtp_rtcp_format/rtp_packet_received.o
[6781/16620] CXX obj/third_party/webrtc/modules/rtp_rtcp/rtp_rtcp_format/rtp_header_extension_map.o
[6782/16620] CXX obj/third_party/webrtc/modules/rtp_rtcp/rtp_rtcp/rtp_payload_registry.o
[6783/16620] CXX obj/third_party/protobuf/protobuf_lite/arenastring.o
[6784/16620] CXX obj/third_party/webrtc/modules/video_coding/video_coding/rtt_filter.o
building of '/nix/store/dym26zy8a8nmzm168lqp4srak9rdd5i2-qtwebengine-5.11.1.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/f3b51wg4fyp90ba58s9jdpax5vq2fn26-radare2-cutter-1.5.drv': 1 dependencies couldn't be built
error: build of '/nix/store/f3b51wg4fyp90ba58s9jdpax5vq2fn26-radare2-cutter-1.5.drv' failed

@dtzWill
Copy link
Member Author

dtzWill commented Jul 11, 2018

Post-merge review welcome and appreciated as always :).

@dtzWill dtzWill merged commit e1b8e8a into NixOS:master Jul 11, 2018
Mic92
Mic92 reviewed Jul 12, 2018
View reviewed changes
pkgs/development/tools/analysis/radare2-cutter/default.nix
# Fix crash on startup in some situations
postInstall = ''
wrapProgram $out/bin/Cutter \
--prefix QT_PLUGIN_PATH : ${qtbase.bin}/${qtbase.qtPluginPrefix} \
Copy link
Member

@Mic92 Mic92 Jul 12, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In nix qt plugins are read from the nix profile. Prefixing the qtbase sounds like a straight-forward idea. However I wonder if it has any side-effects if then other qt components are loaded from the nix profile with a slightly different version (do they have an internal not-stable ABI?)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, very good point. Fixed here: #43425 . Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @GrahamcOfBorg @Mic92