Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hyperrogue: init at 10.4j #43302

Merged
merged 1 commit into from Jul 11, 2018
Merged

hyperrogue: init at 10.4j #43302

merged 1 commit into from Jul 11, 2018

Conversation

rardiol
Copy link
Contributor

@rardiol rardiol commented Jul 10, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

I wish I was good enough at autoconf to understand why I need to set CPPFLAGS.

Does nixpkgs deal fine with this "10.4j" version naming scheme?

nlewo
nlewo requested changes Jul 10, 2018
View reviewed changes
Copy link
Member

@nlewo nlewo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version format is fine.
You need to manually add the header path because headers are not in /include but in include/SDL.
LGTM otherwise.

pkgs/games/hyperrogue/default.nix Outdated
buildInputs = [ autoreconfHook SDL SDL_ttf SDL_gfx SDL_mixer libpng glew];

meta = with stdenv.lib; {
homepage = "http://www.roguetemple.com/z/hyper/";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove quotes (they are useless around url)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@nlewo
Copy link
Member

nlewo commented Jul 10, 2018

@GrahamcOfBorg build hyperrogue

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: hyperrogue

Partial log (click to expand)

make[2]: Leaving directory '/tmp/nix-build-hyperrogue-10.4j.drv-0/source'
make[1]: Leaving directory '/tmp/nix-build-hyperrogue-10.4j.drv-0/source'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/rp35139abigmcc761l8n9gks4gqhwwxb-hyperrogue-10.4j
shrinking /nix/store/rp35139abigmcc761l8n9gks4gqhwwxb-hyperrogue-10.4j/bin/hyperrogue
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/rp35139abigmcc761l8n9gks4gqhwwxb-hyperrogue-10.4j/bin 
patching script interpreter paths in /nix/store/rp35139abigmcc761l8n9gks4gqhwwxb-hyperrogue-10.4j
checking for references to /tmp/nix-build-hyperrogue-10.4j.drv-0 in /nix/store/rp35139abigmcc761l8n9gks4gqhwwxb-hyperrogue-10.4j...
/nix/store/rp35139abigmcc761l8n9gks4gqhwwxb-hyperrogue-10.4j

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: hyperrogue

Partial log (click to expand)

make[2]: Leaving directory '/build/source'
make[1]: Leaving directory '/build/source'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/qb2d7zak8glskn5d0img6igrwjydmk6a-hyperrogue-10.4j
shrinking /nix/store/qb2d7zak8glskn5d0img6igrwjydmk6a-hyperrogue-10.4j/bin/hyperrogue
strip is /nix/store/0pjsgkxz0rp5baycq5sp2s72lrr5q9sg-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/qb2d7zak8glskn5d0img6igrwjydmk6a-hyperrogue-10.4j/bin
patching script interpreter paths in /nix/store/qb2d7zak8glskn5d0img6igrwjydmk6a-hyperrogue-10.4j
checking for references to /build in /nix/store/qb2d7zak8glskn5d0img6igrwjydmk6a-hyperrogue-10.4j...
/nix/store/qb2d7zak8glskn5d0img6igrwjydmk6a-hyperrogue-10.4j

@nlewo
Copy link
Member

nlewo commented Jul 11, 2018

Thanks!

@nlewo nlewo merged commit 05d273a into NixOS:master Jul 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlewo nlewo nlewo requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rardiol @nlewo @GrahamcOfBorg