treewide: enable working, fix fixable, disable broken tests #44739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7c6f434c
reviewed
Aug 8, 2018
| @@ -31,6 +31,8 @@ stdenv.mkDerivation rec { | |||
|
|
|||
| configureFlags = optional stdenv.isDarwin "--without-x"; | |||
|
|
|||
| doCheck = false; # fails 1 out of 12 tests with "Fontconfig error: Cannot load default config file" | |||
There was a problem hiding this comment.
I wonder if makeFontsConf would help with this… (still a mergeable improvement as-is, of course)
7c6f434c
approved these changes
Aug 8, 2018
|
Failure on aarch64-linux (full log) Attempted: flex, jdupes, libbytesize, libndctl, pango, pmount, qt5.qtwebkit, texinfo, volume_key Partial log (click to expand)
|
matthewbauer
reviewed
Aug 8, 2018
| @@ -33,6 +33,8 @@ stdenv.mkDerivation rec { | |||
| installTargets="install install-tex"; | |||
| ''; | |||
|
|
|||
| checkInputs = [ procps ]; | |||
There was a problem hiding this comment.
Do you know what commands are needed from procps?
|
@7c6f434c
Ok. Thanks! (I have ~100 patches more if this, though. =/)
@volth
These changes are for stdenv built with `config.doCheckByDefault = true` set. Which is not recommended ATM as A LOT of stuff will fail to build. In ~5-10 more PRs on the topic it should become usable by the general public. :)
@matthewbauer
Do you know what commands are needed from procps?
No, I didn't investigate. Does it make a difference? `procps` is `unixtools` on non-linux already anyway.
|
|
Recording/improving test suite runnability is something I consider «non-controversial, and if it is ever controversial I do want to try influencing the outcome even with my current Nixpkgs flamewar effort budget», so please ping me if anything of that kind gets stuck. I do not want to do immediate merge because some meaningful discussion with useful clarifications usully happens. (Argh, I want a sane default for «time to let everyone ask questions even though the change has low actual impact», my mention of «several days» was clearly too long, maybe 25 hours from submission then conclusion of existing discussions is a better formulation) |
Yeah that's okay then. IMO it is usually more helpful to be specific with these so to list out |
|
Failure on x86_64-linux (full log) Attempted: flex, jdupes, libbytesize, libndctl, pango, pmount, qt5.qtwebkit, texinfo, volume_key Partial log (click to expand)
|
|
@7c6f434c
Right, like I said before, it would be nice if merge windows were automated.
But it this instance it's fine anyway, I'm not in a hurry with this patchset, conflicts it generates are very easy to resolve.
@matthewbauer
I see, I'll look into it the next time I'm gonna touch texinfo.
|
|
I retracted `flex` patch from here, I have a bunch more patches for it, so I'll batch them together later.
|
|
Timed out, unknown build status on x86_64-linux (full log) Attempted: jdupes, libbytesize, libndctl, pango, pmount, qt5.qtwebkit, texinfo, volume_key Partial log (click to expand)
|
|
Ugh. I really feel like dumping the rest of the related changes here for the ease of testing.
Would anybody object if I dump like 100 more patches into this PR?
|
|
Timed out, unknown build status on aarch64-linux (full log) Attempted: jdupes, libbytesize, libndctl, pango, pmount, qt5.qtwebkit, texinfo, volume_key Partial log (click to expand)
|
|
Closed in favor of #44825. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yet another^4 followup to #39464.