Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fwupdate: 10 -> 12 #44710

Merged
merged 1 commit into from Aug 26, 2018
Merged

fwupdate: 10 -> 12 #44710

merged 1 commit into from Aug 26, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Aug 8, 2018

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@dtzWill
Copy link
Member Author

dtzWill commented Aug 8, 2018

It was merged with fwupd apparently but I didn't see that until already put this together, happy closing or merging :).

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: fwupdate

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: fwupdate

Partial log (click to expand)

shrinking /nix/store/kbji4anwa1f7nhz2p97ypxqnkf2f9ryy-fwupdate-12/lib/libfwup.so.1.12
shrinking /nix/store/kbji4anwa1f7nhz2p97ypxqnkf2f9ryy-fwupdate-12/bin/fwupdate
gzipping man pages under /nix/store/kbji4anwa1f7nhz2p97ypxqnkf2f9ryy-fwupdate-12/share/man/
strip is /nix/store/1hi76hr87bd1y1q1qjk0lv8nmcjip1c8-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/kbji4anwa1f7nhz2p97ypxqnkf2f9ryy-fwupdate-12/lib  /nix/store/kbji4anwa1f7nhz2p97ypxqnkf2f9ryy-fwupdate-12/bin
patching script interpreter paths in /nix/store/kbji4anwa1f7nhz2p97ypxqnkf2f9ryy-fwupdate-12
/nix/store/kbji4anwa1f7nhz2p97ypxqnkf2f9ryy-fwupdate-12/lib/fwupdate/cleanup: interpreter directive changed from "/bin/sh" to "/nix/store/dkh7l9a4sx7zqh8riqbj3z21sz25p8xy-bash-4.4-p23/bin/sh"
/nix/store/kbji4anwa1f7nhz2p97ypxqnkf2f9ryy-fwupdate-12/share/bash-completion/completions/fwupdate: interpreter directive changed from "/bin/bash" to "/nix/store/dkh7l9a4sx7zqh8riqbj3z21sz25p8xy-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/kbji4anwa1f7nhz2p97ypxqnkf2f9ryy-fwupdate-12...
/nix/store/kbji4anwa1f7nhz2p97ypxqnkf2f9ryy-fwupdate-12

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: fwupdate

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@jtojnar
Copy link
Contributor

jtojnar commented Aug 8, 2018

It would be nice to hear from upstream on the status of fwupdate. From the commit history it does not look very dead.

@xeji
Copy link
Contributor

xeji commented Aug 26, 2018

Well, it's a recent tagged release so merging this update shouldn't hurt. Whether to remove this package in the future is a separate question...

@xeji xeji merged commit 85d5d71 into NixOS:master Aug 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dtzWill @GrahamcOfBorg @jtojnar @xeji