Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

weechat-xmpp: create proper runtime environment #44729

Merged
merged 1 commit into from Aug 13, 2018
Merged

weechat-xmpp: create proper runtime environment #44729

merged 1 commit into from Aug 13, 2018

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Aug 8, 2018 •
edited

Motivation for this change

The weechat-xmpp plugin requires pydns to properly resolve the
XMPP host. Furthermore it's much easier to use substituteAll rather than
messing around with substituteInPlace in a patched file.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Ma27
weechat-xmpp: create proper runtime environment
09e58bc 
The `weechat-xmpp` plugin requires `pydns` to properly resolve the
XMPP host. Furthermore it's much easier to use substituteAll rather than
messing around with substituteInPlace in a patched file.
@LnL7
Copy link
Member

LnL7 commented Aug 8, 2018

@GrahamcOfBorg eval

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: weechat-xmpp

Partial log (click to expand)

no configure script, doing nothing
building
no Makefile, doing nothing
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/sw9py481fphszp1kjdxj7azy5y4wkk6h-weechat-jabber-2017-08-30
strip is /nix/store/1hi76hr87bd1y1q1qjk0lv8nmcjip1c8-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/sw9py481fphszp1kjdxj7azy5y4wkk6h-weechat-jabber-2017-08-30
checking for references to /build in /nix/store/sw9py481fphszp1kjdxj7azy5y4wkk6h-weechat-jabber-2017-08-30...
/nix/store/sw9py481fphszp1kjdxj7azy5y4wkk6h-weechat-jabber-2017-08-30

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: weechat-xmpp

Partial log (click to expand)

no configure script, doing nothing
building
no Makefile, doing nothing
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/7dk93ahkl7bsh2afyiswmcznx7mqmlnr-weechat-jabber-2017-08-30
strip is /nix/store/zrs21zqcchgyabjf4xfimncdq16njizc-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/7dk93ahkl7bsh2afyiswmcznx7mqmlnr-weechat-jabber-2017-08-30
checking for references to /build in /nix/store/7dk93ahkl7bsh2afyiswmcznx7mqmlnr-weechat-jabber-2017-08-30...
/nix/store/7dk93ahkl7bsh2afyiswmcznx7mqmlnr-weechat-jabber-2017-08-30

@Ma27
Copy link
Member Author

Ma27 commented Aug 13, 2018

@LnL7 is there anything that keeps this patch from merging? %)

@LnL7
Copy link
Member

LnL7 commented Aug 13, 2018 •
edited

@GrahamcOfBorg build weechat-xmpp

I triggered a manual eval on a bunch of pull requests because of pull requests because of ofborg maintenance. I'm not familiar with the package, but the changes look sane.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: weechat-xmpp

Partial log (click to expand)

no configure script, doing nothing
building
no Makefile, doing nothing
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/19izxj4kd17nnkaqrizjach74f2hcdfs-weechat-jabber-2017-08-30
strip is /nix/store/gpc2wld1s0c6qzx9326cwn1wcx29xzsj-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/19izxj4kd17nnkaqrizjach74f2hcdfs-weechat-jabber-2017-08-30
checking for references to /build in /nix/store/19izxj4kd17nnkaqrizjach74f2hcdfs-weechat-jabber-2017-08-30...
/nix/store/19izxj4kd17nnkaqrizjach74f2hcdfs-weechat-jabber-2017-08-30

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: weechat-xmpp

Partial log (click to expand)

no configure script, doing nothing
building
no Makefile, doing nothing
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/148kb873w53dzd89p1pmrsx42i0hgpr2-weechat-jabber-2017-08-30
strip is /nix/store/ah0va6j4cnwj9nx4j6rwcfc8nh785jwm-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/148kb873w53dzd89p1pmrsx42i0hgpr2-weechat-jabber-2017-08-30
checking for references to /build in /nix/store/148kb873w53dzd89p1pmrsx42i0hgpr2-weechat-jabber-2017-08-30...
/nix/store/148kb873w53dzd89p1pmrsx42i0hgpr2-weechat-jabber-2017-08-30

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: weechat-xmpp

Partial log (click to expand)

patching file jabber.py
configuring
no configure script, doing nothing
building
no Makefile, doing nothing
installing
post-installation fixup
strip is /nix/store/251fvx4mx9q4zarbca5cciasmn66p668-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/348l1z6qpjsgvr1dh6h2232fi1czw807-weechat-jabber-2017-08-30
/nix/store/348l1z6qpjsgvr1dh6h2232fi1czw807-weechat-jabber-2017-08-30

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: weechat-xmpp

Partial log (click to expand)

/nix/store/148kb873w53dzd89p1pmrsx42i0hgpr2-weechat-jabber-2017-08-30

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: weechat-xmpp

Partial log (click to expand)

no configure script, doing nothing
building
no Makefile, doing nothing
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/19izxj4kd17nnkaqrizjach74f2hcdfs-weechat-jabber-2017-08-30
strip is /nix/store/gpc2wld1s0c6qzx9326cwn1wcx29xzsj-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/19izxj4kd17nnkaqrizjach74f2hcdfs-weechat-jabber-2017-08-30
checking for references to /build in /nix/store/19izxj4kd17nnkaqrizjach74f2hcdfs-weechat-jabber-2017-08-30...
/nix/store/19izxj4kd17nnkaqrizjach74f2hcdfs-weechat-jabber-2017-08-30

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: weechat-xmpp

Partial log (click to expand)

patching file jabber.py
configuring
no configure script, doing nothing
building
no Makefile, doing nothing
installing
post-installation fixup
strip is /nix/store/251fvx4mx9q4zarbca5cciasmn66p668-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/348l1z6qpjsgvr1dh6h2232fi1czw807-weechat-jabber-2017-08-30
/nix/store/348l1z6qpjsgvr1dh6h2232fi1czw807-weechat-jabber-2017-08-30

@LnL7 LnL7 merged commit 3d43640 into NixOS:master Aug 13, 2018
@Ma27 Ma27 deleted the fix-weechat-xmpp branch August 13, 2018 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ma27 @LnL7 @GrahamcOfBorg