gallery: don't generate index page on empty output folder #3134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty output folder allows galleries to be placed at the site's top directory, instead of inside e.g. a "galleries" subdirectory. But without this change, the plugin would want to generate an index page that collides with the site's main index page. Fixes getnikola#3134
evetsso
force-pushed
the
gallery-toplevel
branch
from
e742846
to
2297526
Compare
Kwpolska
approved these changes
Aug 8, 2018
|
Come to think of it, this breaks sites that are gallery-centric (who want the gallery index as main). I slightly amended it in commit 1220595. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Empty output folder allows galleries to be placed at the site's top directory,
instead of inside e.g. a "galleries" subdirectory. But without this change, the
plugin would want to generate an index page that collides with the site's main
index page.
Pull Request Checklist
Description
I don't think this requires a documentation change? Attempting to use an empty output folder for galleries I think just follows naturally without needing it explicitly mentioned?