Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pyserial: fix build on Darwin #44073

Merged
merged 1 commit into from Jul 25, 2018
Merged

pyserial: fix build on Darwin #44073

merged 1 commit into from Jul 25, 2018

Conversation

lukeadams
Copy link
Contributor

@lukeadams lukeadams commented Jul 25, 2018 •
edited

Motivation for this change

Disables hanging tests to fix the build

py2
py3

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@lukeadams lukeadams requested a review from FRidh as a code owner July 25, 2018 02:55
@matthewbauer
Copy link
Member

I think the doInstallCheck thing was probably a mistake. I thought that the failing tests were install checks. Does pyserial still build if you remove it?

@lukeadams
Copy link
Contributor Author

lukeadams commented Jul 25, 2018 •
edited

Didn't even think to check but yeah, only the doCheck portion is necessary. Should be pushed now!

@matthewbauer
Copy link
Member

Ok nice. That was my bad.

@matthewbauer matthewbauer merged commit a79d917 into NixOS:master Jul 25, 2018
@lukeadams
Copy link
Contributor Author

lukeadams commented Jul 25, 2018 via email

@lukeadams lukeadams deleted the pyserial-darwin-fix branch May 26, 2021 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lukeadams @matthewbauer @GrahamcOfBorg