Add qcomicbook. #44074
Merged
Add qcomicbook. #44074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg build qcomicbook Hi! first PR there :) grats! @GrahamcOfBorg is our CI pipeline, builds can be queued and thus tested this way (you need permission first for builds). You will soon see the results on each platforms for the build. |
|
Success on x86_64-linux (full log) Attempted: qcomicbook Partial log (click to expand)
|
|
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: qcomicbook Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: qcomicbook Partial log (click to expand)
|
| with stdenv.lib; | ||
|
|
||
| let | ||
| version = "0.9.1"; |
There was a problem hiding this comment.
It's best practice to define the version like this:
stdenv.mkDerivation rec {
name = "qcomicbook-${version}";
version = "0.9.1";
...
}
| description = "Comic book reader in Qt5"; | ||
| license = licenses.gpl2; | ||
|
|
||
| longDescription = ''QComicBook is a viewer for PDF files and comic book archives containing |
There was a problem hiding this comment.
Nit: The preferred formatting is:
longDescription = ''
QComicBook is a viewer...
'';
|
I've added a few minor changes that you might want to copy and then it looks about perfect: Welcome to |
|
Neat! I didn't know about fetchFromGithub. Thanks! |
|
@GrahamcOfBorg build qcomicbook |
|
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: qcomicbook Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: qcomicbook Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: qcomicbook Partial log (click to expand)
|
matthewbauer
approved these changes
Aug 2, 2018
xeji
reviewed
Aug 3, 2018
There was a problem hiding this comment.
Please modify according to nixpkgs conventions for qt applications.
|
@xeji done. Sorry that it took this long. |
|
Thank you! |
|
Success on x86_64-linux (full log) Attempted: qcomicbook Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: qcomicbook Partial log (click to expand)
|
|
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: qcomicbook Partial log (click to expand)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Having this program in NixOS.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)