Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/release: use real paths of netboot files #44089

Merged
merged 1 commit into from Jul 30, 2018
Merged

nixos/release: use real paths of netboot files #44089

merged 1 commit into from Jul 30, 2018

Conversation

lheckemann
Copy link
Member

Motivation for this change

Enabling placing netboot files in channels so we can add https://netboot.xyz support. See also netbootxyz/netboot.xyz#37

I'm not sure if this works the way I hope it does, since the build product paths aren't within the derivation. Input from someone who knows things about hydra would be appreciated! If it doesn't work, I will open an alternative PR which copies the files instead (but increases the closure size of the release jobs by >500M and thus isn't very desirable…).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 mentioned this pull request Jul 30, 2018
Closed
@matthewbauer
Copy link
Member

matthewbauer commented Jul 30, 2018 •
edited

Looks like you're okay to use outside build products:

https://github.com/NixOS/hydra/blob/a3efdcdfd910aabd3001467864eaf2990f6c57a2/src/hydra-queue-runner/build-result.cc#L64-L7

at least for now. Maybe just get rid of the symlinkJoin stuff and just do runCommand though?

@lheckemann
Copy link
Member Author

I don't see any good reason to get rid of the symlinkJoin really. Thanks for hunting down the outside build products thing!

@matthewbauer matthewbauer merged commit 5afe87e into NixOS:master Jul 30, 2018
@lheckemann lheckemann deleted the netboot-channel-v2 branch August 1, 2018 12:38
@lheckemann
Copy link
Member Author

Cross-ref: this is a workaround for NixOS/hydra#580

@lheckemann lheckemann mentioned this pull request Aug 1, 2018
Closed
@lheckemann
Copy link
Member Author

Could we have a backport to 18.03 as well? cc @fpletz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lheckemann @matthewbauer @GrahamcOfBorg