Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eot_utilities: change platforms to unix #44071

Merged
merged 1 commit into from Jul 25, 2018
Merged

eot_utilities: change platforms to unix #44071

merged 1 commit into from Jul 25, 2018

Conversation

eqyiel
Copy link
Contributor

@eqyiel eqyiel commented Jul 25, 2018

Motivation for this change

This works on Darwin too.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@eqyiel
eot_utilities: change platforms to unix
0438900 
This works on Darwin too.
@matthewbauer
Copy link
Member

@GrahamcOfBorg build eot_utilities

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: eot_utilities

Partial log (click to expand)

these paths will be fetched (0.01 MiB download, 0.04 MiB unpacked):
  /nix/store/hmna5wz72y1hdm63nc9hgy7107j6sw27-eot_utilities-1.1
copying path '/nix/store/hmna5wz72y1hdm63nc9hgy7107j6sw27-eot_utilities-1.1' from 'https://cache.nixos.org'...
/nix/store/hmna5wz72y1hdm63nc9hgy7107j6sw27-eot_utilities-1.1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: eot_utilities

Partial log (click to expand)

these paths will be fetched (0.01 MiB download, 0.04 MiB unpacked):
  /nix/store/8pfppqr80lsgz4p3prvihngqi2is07n7-eot_utilities-1.1
copying path '/nix/store/8pfppqr80lsgz4p3prvihngqi2is07n7-eot_utilities-1.1' from 'https://cache.nixos.org'...
/nix/store/8pfppqr80lsgz4p3prvihngqi2is07n7-eot_utilities-1.1

@matthewbauer
Copy link
Member

I am waiting on OfBorg but it has been having some issues on darwin lately. If someone else can independently verify that it builds for them that should be enough to merge this.

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: eot_utilities

Partial log (click to expand)

  /nix/store/qm5zn979n56z1vwhf3wh1r7zkw6z581j-coreutils-8.29/bin/install -c mkeot eotinfo '/nix/store/asi20xcj02q4gsi8p59fbv7nrg2qcky8-eot_utilities-1.1/bin'
test -z "/nix/store/asi20xcj02q4gsi8p59fbv7nrg2qcky8-eot_utilities-1.1/share/man/man1" || /nix/store/qm5zn979n56z1vwhf3wh1r7zkw6z581j-coreutils-8.29/bin/mkdir -p "/nix/store/asi20xcj02q4gsi8p59fbv7nrg2qcky8-eot_utilities-1.1/share/man/man1"
 /nix/store/qm5zn979n56z1vwhf3wh1r7zkw6z581j-coreutils-8.29/bin/install -c -m 644 mkeot.1 eotinfo.1 '/nix/store/asi20xcj02q4gsi8p59fbv7nrg2qcky8-eot_utilities-1.1/share/man/man1'
make[1]: Leaving directory '/private/tmp/nix-build-eot_utilities-1.1.drv-0/eot-utilities-1.1'
post-installation fixup
gzipping man pages under /nix/store/asi20xcj02q4gsi8p59fbv7nrg2qcky8-eot_utilities-1.1/share/man/
strip is /nix/store/sixx1lfy97125f6hxymbwn64cb8z62p3-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/asi20xcj02q4gsi8p59fbv7nrg2qcky8-eot_utilities-1.1/bin
patching script interpreter paths in /nix/store/asi20xcj02q4gsi8p59fbv7nrg2qcky8-eot_utilities-1.1
/nix/store/asi20xcj02q4gsi8p59fbv7nrg2qcky8-eot_utilities-1.1

@matthewbauer matthewbauer merged commit 7b73962 into NixOS:master Jul 25, 2018
@eqyiel eqyiel deleted the eot_utilities-darwin branch November 3, 2020 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eqyiel @matthewbauer @GrahamcOfBorg